2key2crawl board for ATX Keycrawl 2018 #4532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mechmerlin
requested changes
Dec 2, 2018
|
|
||
| #include "quantum.h" | ||
|
|
||
| #define KEYMAP( \ |
There was a problem hiding this comment.
Suggested change
| #define KEYMAP( \ | |
| #define LAYOUT( \ |
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
|
||
| KEYMAP( |
There was a problem hiding this comment.
Suggested change
| KEYMAP( | |
| LAYOUT( |
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
|
||
| KEYMAP( |
There was a problem hiding this comment.
Suggested change
| KEYMAP( | |
| LAYOUT( |
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
|
||
| KEYMAP( |
There was a problem hiding this comment.
Suggested change
| KEYMAP( | |
| LAYOUT( |
| # Build Options | ||
| # comment out to disable the options. | ||
| # | ||
| BOOTMAGIC_ENABLE ?= no # Virtual DIP switch configuration(+1000) |
There was a problem hiding this comment.
Suggested change
| BOOTMAGIC_ENABLE ?= no # Virtual DIP switch configuration(+1000) | |
| BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration(+1000) |
| EXTRAKEY_ENABLE ?= no # Audio control and System control(+450) | ||
| CONSOLE_ENABLE ?= yes # Console for debug(+400) | ||
| COMMAND_ENABLE ?= no # Commands for debug and configuration | ||
| SLEEP_LED_ENABLE ?= no # Breathing sleep LED during USB suspend |
There was a problem hiding this comment.
Suggested change
| SLEEP_LED_ENABLE ?= no # Breathing sleep LED during USB suspend | |
| SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| CONSOLE_ENABLE ?= yes # Console for debug(+400) | ||
| COMMAND_ENABLE ?= no # Commands for debug and configuration | ||
| SLEEP_LED_ENABLE ?= no # Breathing sleep LED during USB suspend | ||
| NKRO_ENABLE ?= no # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
There was a problem hiding this comment.
Suggested change
| NKRO_ENABLE ?= no # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | |
| NKRO_ENABLE = no # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
| COMMAND_ENABLE ?= no # Commands for debug and configuration | ||
| SLEEP_LED_ENABLE ?= no # Breathing sleep LED during USB suspend | ||
| NKRO_ENABLE ?= no # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | ||
| BACKLIGHT_ENABLE ?= no # [Crawlpad] Custom backlighting code is used, so this should not be enabled |
There was a problem hiding this comment.
Suggested change
| BACKLIGHT_ENABLE ?= no # [Crawlpad] Custom backlighting code is used, so this should not be enabled | |
| BACKLIGHT_ENABLE = no # [Crawlpad] Custom backlighting code is used, so this should not be enabled |
| SLEEP_LED_ENABLE ?= no # Breathing sleep LED during USB suspend | ||
| NKRO_ENABLE ?= no # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | ||
| BACKLIGHT_ENABLE ?= no # [Crawlpad] Custom backlighting code is used, so this should not be enabled | ||
| AUDIO_ENABLE ?= no # [Crawlpad] This can be enabled if a speaker is connected to the expansion port. Not compatible with RGBLIGHT below |
There was a problem hiding this comment.
Suggested change
| AUDIO_ENABLE ?= no # [Crawlpad] This can be enabled if a speaker is connected to the expansion port. Not compatible with RGBLIGHT below | |
| AUDIO_ENABLE = no # [Crawlpad] This can be enabled if a speaker is connected to the expansion port. Not compatible with RGBLIGHT below |
| NKRO_ENABLE ?= no # USB Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | ||
| BACKLIGHT_ENABLE ?= no # [Crawlpad] Custom backlighting code is used, so this should not be enabled | ||
| AUDIO_ENABLE ?= no # [Crawlpad] This can be enabled if a speaker is connected to the expansion port. Not compatible with RGBLIGHT below | ||
| RGBLIGHT_ENABLE ?= no # [Crawlpad] This can be enabled if a ws2812 strip is connected to the expansion port. |
There was a problem hiding this comment.
Suggested change
| RGBLIGHT_ENABLE ?= no # [Crawlpad] This can be enabled if a ws2812 strip is connected to the expansion port. | |
| RGBLIGHT_ENABLE = no # [Crawlpad] This can be enabled if a ws2812 strip is connected to the expansion port. |
|
Just wanted to touch base here. Any update on this? |
|
@colemarkham any progress here? we'd like to either merge or close this. |
|
@colemarkham Thanks for submitting this change. It looks like it needs some work before it can be accepted. Will you be working on this, or can we close it to clean up our PR queue? |
|
Thanks for submitting this PR. Unfortunately we were not able to accept it in its current state. We invite you to clean this branch up and resubmit, but for now we are going to close this PR to clean up our queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.