Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding default settings for ERM motors for Hadron v3 haptic feedback #4761

Merged
merged 3 commits into from
Jan 2, 2019
Merged

Adding default settings for ERM motors for Hadron v3 haptic feedback #4761

merged 3 commits into from
Jan 2, 2019

Conversation

ishtob
Copy link
Contributor

@ishtob ishtob commented Jan 2, 2019 •
edited
Loading

Description

adding settings for using ERM motors (cellphone-type vibration motors) instead of standard LRA drivers for haptic feedback

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ishtob ishtob changed the title Hadron v3 erm Adding default settings for ERM motors for Hadron v3 haptic feedback Jan 2, 2019
mechmerlin
mechmerlin approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mechmerlin mechmerlin merged commit 484c85b into qmk:master Jan 2, 2019
@ishtob ishtob deleted the hadronV3-ERM branch January 2, 2019 21:31
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
@ishtob @rseymour
Adding default settings for ERM motors for Hadron v3 haptic feedback (q…
29487e7 
…mk#4761)

* adding default settings to support 3v ERM vibration motors

* set default settings of haptic motor for LV061228B-L64-A 2v LRA

* update ishtob keymap and fix config settings
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
@ishtob @djthread
Adding default settings for ERM motors for Hadron v3 haptic feedback (q…
dc6ffae 
…mk#4761)

* adding default settings to support 3v ERM vibration motors

* set default settings of haptic motor for LV061228B-L64-A 2v LRA

* update ishtob keymap and fix config settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishtob @mechmerlin