-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added personal keymaps for Planck, Preonic, Vitamins Included by Juno #5169
Conversation
Actually, since the Planck and the Lets Split Vitamins Included board use the same layout, and it looks like the code is very similar, if not identical, you may want to just use That would allow you to have one file that would work with both keyboards. |
So sorry for having taken long to reply. Life has been crazy and this slipped off my mind. New commit removed redundancies as requested. Let me know if I missed anything.
There are differences between these two boards that make me want to keep apart them at the moment. I'd definitely look into this into the future (didn't know this was possible, so thanks for the headsup). |
Not a problem, life happens! For the layout stuff, you can use So there are ways to differentiate. But that's completely optional, and if you prefer it this way, that's fine! |
Again, will consider it when I have more time for testing. Let me know what else I need to get this pull request approved. (Or is it one of them?) |
…d by Juno (qmk#5169) * Added personal keymaps for Planck, Preonic, Vitamins Included by Juno * Removing redundancies as suggested * More removals that were missed out in the previous commits * Updated Preonic to use new layout * More redundancies missed out * Updated more optimal code for FN layer LED indicator. * Further codes clean up.
…d by Juno (qmk#5169) * Added personal keymaps for Planck, Preonic, Vitamins Included by Juno * Removing redundancies as suggested * More removals that were missed out in the previous commits * Updated Preonic to use new layout * More redundancies missed out * Updated more optimal code for FN layer LED indicator. * Further codes clean up.
…d by Juno (qmk#5169) * Added personal keymaps for Planck, Preonic, Vitamins Included by Juno * Removing redundancies as suggested * More removals that were missed out in the previous commits * Updated Preonic to use new layout * More redundancies missed out * Updated more optimal code for FN layer LED indicator. * Further codes clean up.
…d by Juno (qmk#5169) * Added personal keymaps for Planck, Preonic, Vitamins Included by Juno * Removing redundancies as suggested * More removals that were missed out in the previous commits * Updated Preonic to use new layout * More redundancies missed out * Updated more optimal code for FN layer LED indicator. * Further codes clean up.
…d by Juno (qmk#5169) * Added personal keymaps for Planck, Preonic, Vitamins Included by Juno * Removing redundancies as suggested * More removals that were missed out in the previous commits * Updated Preonic to use new layout * More redundancies missed out * Updated more optimal code for FN layer LED indicator. * Further codes clean up.
Description
My personal keymaps for Planck, Preonic and the Vitamins Included version of Let's Split.
Types of Changes
Issues Fixed or Closed by This PR
Checklist