Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added personal keymaps for Planck, Preonic, Vitamins Included by Juno #5169

Merged
merged 7 commits into from
Feb 28, 2019
Merged

Added personal keymaps for Planck, Preonic, Vitamins Included by Juno #5169

merged 7 commits into from
Feb 28, 2019

Conversation

JunoNgx
Copy link
Contributor

@JunoNgx JunoNgx commented Feb 18, 2019

Description

My personal keymaps for Planck, Preonic and the Vitamins Included version of Let's Split.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • [ X] Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [X ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Feb 18, 2019

Actually, since the Planck and the Lets Split Vitamins Included board use the same layout, and it looks like the code is very similar, if not identical, you may want to just use layouts/community/juno instead.

That would allow you to have one file that would work with both keyboards.
https://docs.qmk.fm/#/feature_layouts

keyboards/planck/keymaps/juno/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/juno/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/juno/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/juno/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/juno/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/juno/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/juno/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/juno/keymap.c Outdated Show resolved Hide resolved
keyboards/vitamins_included/keymaps/juno/keymap.c Outdated Show resolved Hide resolved
keyboards/vitamins_included/keymaps/juno/keymap.c Outdated Show resolved Hide resolved
@drashna drashna added the keymap label Feb 18, 2019
@JunoNgx
Copy link
Contributor Author

JunoNgx commented Feb 23, 2019

So sorry for having taken long to reply. Life has been crazy and this slipped off my mind.

New commit removed redundancies as requested. Let me know if I missed anything.

Actually, since the Planck and the Lets Split Vitamins Included board use the same layout, and it looks like the code is very similar, if not identical, you may want to just use layouts/community/juno instead.

That would allow you to have one file that would work with both keyboards.
https://docs.qmk.fm/#/feature_layouts

There are differences between these two boards that make me want to keep apart them at the moment. I'd definitely look into this into the future (didn't know this was possible, so thanks for the headsup).

@drashna
Copy link
Member

drashna commented Feb 26, 2019

Not a problem, life happens!

For the layout stuff, you can use #ifdef KEYBOARD_planck to tell if it's a planck board, for instance.
Or, each feature usually has a define for it, that matches the rules.mk setting name.

So there are ways to differentiate.

But that's completely optional, and if you prefer it this way, that's fine!

@JunoNgx
Copy link
Contributor Author

JunoNgx commented Feb 26, 2019

Again, will consider it when I have more time for testing.

Let me know what else I need to get this pull request approved.

(Or is it one of them?)

@drashna drashna merged commit 3ac3bb9 into qmk:master Feb 28, 2019
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
…d by Juno (qmk#5169)

* Added personal keymaps for Planck, Preonic, Vitamins Included by Juno

* Removing redundancies as suggested

* More removals that were missed out in the previous commits

* Updated Preonic to use new layout

* More redundancies missed out

* Updated more optimal code for FN layer LED indicator.

* Further codes clean up.
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 18, 2019
…d by Juno (qmk#5169)

* Added personal keymaps for Planck, Preonic, Vitamins Included by Juno

* Removing redundancies as suggested

* More removals that were missed out in the previous commits

* Updated Preonic to use new layout

* More redundancies missed out

* Updated more optimal code for FN layer LED indicator.

* Further codes clean up.
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
…d by Juno (qmk#5169)

* Added personal keymaps for Planck, Preonic, Vitamins Included by Juno

* Removing redundancies as suggested

* More removals that were missed out in the previous commits

* Updated Preonic to use new layout

* More redundancies missed out

* Updated more optimal code for FN layer LED indicator.

* Further codes clean up.
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
…d by Juno (qmk#5169)

* Added personal keymaps for Planck, Preonic, Vitamins Included by Juno

* Removing redundancies as suggested

* More removals that were missed out in the previous commits

* Updated Preonic to use new layout

* More redundancies missed out

* Updated more optimal code for FN layer LED indicator.

* Further codes clean up.
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
…d by Juno (qmk#5169)

* Added personal keymaps for Planck, Preonic, Vitamins Included by Juno

* Removing redundancies as suggested

* More removals that were missed out in the previous commits

* Updated Preonic to use new layout

* More redundancies missed out

* Updated more optimal code for FN layer LED indicator.

* Further codes clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants