Eager pk/pr optimization #5621
Merged
Eager pk/pr optimization #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested. And this appears to fix #5621 |
drashna
requested review from
drashna,
ezuk,
jackhumbert,
mechmerlin,
skullydazed and
yanfali
drashna
approved these changes
Apr 15, 2019
Works... but i don't know why... |
|
So an interesting possible future extention using a dirty boolean: if scanning a large matrix takes too much time, you could switch that boolean to a dirty mask that can identify smaller portions of the matrix that need to be scanned for debounce. I do that in the oled driver pr #5288 as an example. |
jackhumbert
approved these changes
Apr 15, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Apr 17, 2019
* Optimizations to eager_pk * eager_pr also uses changed boolean now.
foosinn
pushed a commit
to foosinn/qmk_firmware
that referenced
this pull request
May 6, 2019
* Optimizations to eager_pk * eager_pr also uses changed boolean now.
shimesaba-type0
pushed a commit
to shimesaba-type0/qmk_firmware
that referenced
this pull request
Jun 22, 2019
* Optimizations to eager_pk * eager_pr also uses changed boolean now.
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* Optimizations to eager_pk * eager_pr also uses changed boolean now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eager pk/pr will now have effectively 0 runtime when no debouncing is required
Description
A boolean stores whether we are currently debouncing anything.
We can skip scanning the matrix if we are are not debouncing.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Haven't gotten around to testing the changes due to no qmk keyboard easily available.
May alleviate #5620, though i see no reason why it would.