Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal keymap for the planck with muzak #6402

Merged
merged 5 commits into from
Jul 27, 2019

Conversation

sidcarter
Copy link
Contributor

@sidcarter sidcarter commented Jul 24, 2019

Personal keymap for the planck with muzak

Description

  • Has Colemak on a layer
  • Enables mouse layer, but does not activate it yet
  • Has Muzak and Sounds (Wheeee)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of more minor things, but otherwise, it looks good!

keyboards/planck/keymaps/skank/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/skank/keymap.c Outdated Show resolved Hide resolved
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@drashna drashna merged commit cd7bc03 into qmk:master Jul 27, 2019
@sidcarter sidcarter deleted the sid_planck_colemak branch July 27, 2019 13:56
raymond-w-ko pushed a commit to raymond-w-ko/qmk_firmware that referenced this pull request Aug 4, 2019
* personal keymap for the planck with sounds

* need that minus and underscore where I can see them

* remove unused block

* some, shall we call them, minor changes?

* I don't think this is required anymore
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
* personal keymap for the planck with sounds

* need that minus and underscore where I can see them

* remove unused block

* some, shall we call them, minor changes?

* I don't think this is required anymore
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
* personal keymap for the planck with sounds

* need that minus and underscore where I can see them

* remove unused block

* some, shall we call them, minor changes?

* I don't think this is required anymore
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* personal keymap for the planck with sounds

* need that minus and underscore where I can see them

* remove unused block

* some, shall we call them, minor changes?

* I don't think this is required anymore
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* personal keymap for the planck with sounds

* need that minus and underscore where I can see them

* remove unused block

* some, shall we call them, minor changes?

* I don't think this is required anymore
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
* personal keymap for the planck with sounds

* need that minus and underscore where I can see them

* remove unused block

* some, shall we call them, minor changes?

* I don't think this is required anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants