Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One-line build fix #6421

Merged
merged 1 commit into from
Jul 27, 2019
Merged

One-line build fix #6421

merged 1 commit into from
Jul 27, 2019

Conversation

yrdns
Copy link
Contributor

@yrdns yrdns commented Jul 26, 2019

One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL

Description

Ran into this when customizing keymaps. Given the code structure + comment, I assume this was what the code was originally supposed to be, and current version was an oversight

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yrdns
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_…
37a3c01 
…CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
@drashna drashna added the bug label Jul 27, 2019
@drashna drashna merged commit 22a8992 into qmk:master Jul 27, 2019
@Lenbok
Copy link
Contributor

Lenbok commented Jul 27, 2019

Funny/sad - I fixed this exact problem in #5561 but it must have been reintroduced!

@drashna
Copy link
Member

drashna commented Jul 27, 2019

Well, I know whose probably to blame :D

@XScorpion2
Copy link
Contributor

99% sure it was me during a bad mere / rebase.

@Lenbok
Copy link
Contributor

Lenbok commented Jul 28, 2019

Your ratio of steps forward to steps backwards is still looking pretty healthy though :).

@drashna
Copy link
Member

drashna commented Jul 28, 2019

Definitely agree. A misstep here or there is forgivable. And not like I haven't done worse.

drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 2, 2019
@yrdns @drashna
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
46384ef 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
raymond-w-ko pushed a commit to raymond-w-ko/qmk_firmware that referenced this pull request Aug 4, 2019
@yrdns @raymond-w-ko
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
2835b46 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 13, 2019
@yrdns @fdidron
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
48db06e 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@yrdns @doughsay
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
4b8f7ba 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
@yrdns @drashna
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
1fad45a 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@yrdns
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
98a55b5 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@yrdns @drashna
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
8ffc310 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@yrdns @swamp09
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
7a8ba5f 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@yrdns @drashna
Fix RGB Matrix Cycle Left-Right Animation (qmk#6421)
a3133c4 
One-line fix for a typo that could break build if DISABLE_RGB_MATRIX_CYCLE_LEFT_RIGHT was defined but not DISABLE_RGB_MATRIX_CYCLE_ALL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XScorpion2 XScorpion2 XScorpion2 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yrdns @Lenbok @drashna @XScorpion2