Arm ps2 mouse interrupt #6490

JohSchneider · 2019-08-05T18:31:49Z

Description

these patches add an PS2 mouse driver for ChibiOS based boards; The AVR ps2-interrupt-code is reused as much as possible, and parts that are platform specific are either split off or switched with defines.

Tested&Verified on a STM32F103 board with an Cherry-ML-4400 PS2-trackball :-)

Types of Changes

drashna

You shouldn't need to add defines for the delay.

In fact, all of them should be changed to wait_**, as this is hardware agnostic, and should be defined for us.

tmk_core/protocol/ps2_interrupt.c

JohSchneider · 2019-08-06T19:12:49Z

good find! 34175dc fixes that

docs/feature_ps2_mouse.md

tmk_core/protocol/ps2_interrupt.c

zvecr · 2019-08-07T22:52:37Z

tmk_core/protocol/ps2_io_chibios.c

+
+void clock_lo(void)
+{
+    palSetLineMode(PS2_LINE_CLOCK, PAL_MODE_OUTPUT_OPENDRAIN);


Does EXT require use of PAL_MODE_ALTERNATE on non GPIOv1 boards (for example f303 which is GPIOv2)?

good question - dunno :-)
here on GPIOv1/stm32f1 the pins are in no special/alternate mode - probably applies to other stms as well...

My understanding is very few boards run GPIOv1, and the majority of QMK supported boards are GPIOv2. I would personally like to see this answered before merging, given the current state of the repo. That way it can either be documented, or protected with compile time errors.

ok, from what i can tell - grepping through the sources and docs - the EXT driver only uses the pins as they are configured for example with PAL_MODE_OUTPUT_? - no special/alternate mode anywhere. and the EXT driver is available on other STM32F? as well. so i see no problems there

but do note, that the EXT driver is considered legacy - newer chibios versions use per line/pad events that can have a callback function assigned (palEnableLineEvent and palSetLineCallback) - see the comments in my code
yes this adds a minor hurdle when QMK decides to move to a newer chibios version - but i did my best to document that :-)

ChibiOS has been updated since, so this PR may need some TLC before it's ready to merge.

hugovk

Some suggestions for the docs, otherwise looks good.

docs/feature_ps2_mouse.md

samagragupta

docs/feature_ps2_mouse.md

tmk_core/protocol/ps2_interrupt.c

tmk_core/protocol/ps2_mouse.c

tmk_core/protocol/ps2_interrupt.c

docs/feature_ps2_mouse.md

tmk_core/protocol/ps2_interrupt.c

tmk_core/protocol/ps2_mouse.c

parammittal16

…o ARM/chibios

…ined PS2_LINE_CLOCK

tmk_core/protocol/ps2_interrupt.c

using the chibios equivalent to AVRs cli: chSys[Unl|L]ock

JohSchneider · 2020-05-20T17:03:58Z

@twadleigh thanks!
since you seem to be using this code - mind testing it in your setup, and posting some feedback :)

tzarc

Seems fine, but no hardware to test with... would be great to get some feedback from users.

tzarc · 2020-07-25T03:11:08Z

Retargeted this to develop due to core changes.

* ps2_mouse on ARM: an interrupt-version of the ps2-mouse code ported to ARM/chibios * ps2_mouse on ARM: link EXT callback-channel selection to the user defined PS2_LINE_CLOCK * ps2_mouse on ARM: replace DELAY_X defines with hardware-agnostic wait_X * ps2_mouse on ARM: replace chibios-specific defines for the pins/lines with defines from quantum/config_common.h and drop the '_LINE' component from teh define name * ps2_mouse on ARM: expose the software-intterupt port as a user editable define * Update docs/feature_ps2_mouse.md Co-Authored-By: Hugo van Kemenade <hugovk@users.noreply.github.com> * Update feature_ps2_mouse.md * use a define to deduce the PS_DATA_PORT instead * reduce all-zero extcfg to oneliner * ps2_mouse: use generic wait instead of avr-delay * Update docs/feature_ps2_mouse.md * ps2_mouse: changes for new chibios version (17.6.0 -> 19.1.0) replacing the legacy externa-interrupt driver with pal-callbacks * ps2_mouse: use PLATFORM_KEY Co-Authored-By: Joel Challis <git@zvecr.com> * ps2_mouse: clang-format corrections * ps2_mouse: add systemlocks using the chibios equivalent to AVRs cli: chSys[Unl|L]ock Co-authored-by: Johannes <you@example.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Joel Challis <git@zvecr.com>

JohSchneider force-pushed the arm_ps2-mouse_interrupt branch 2 times, most recently from 0966d98 to 294f017 Compare August 6, 2019 13:37

drashna requested changes Aug 6, 2019

View reviewed changes

drashna added core enhancement documentation labels Aug 6, 2019

zvecr reviewed Aug 7, 2019

View reviewed changes

drashna requested review from drashna and a team August 8, 2019 20:34

JohSchneider force-pushed the arm_ps2-mouse_interrupt branch 2 times, most recently from 082af25 to 5e50864 Compare August 9, 2019 12:55

jackhumbert added the hacktoberfest-accepted All the good issues to tackle during Hacktoberfest! label Sep 30, 2019

hugovk reviewed Oct 6, 2019

View reviewed changes

docs/feature_ps2_mouse.md Outdated Show resolved Hide resolved

docs/feature_ps2_mouse.md Outdated Show resolved Hide resolved

docs/feature_ps2_mouse.md Outdated Show resolved Hide resolved

samagragupta approved these changes Oct 19, 2019

View reviewed changes

zvecr requested changes Oct 19, 2019

View reviewed changes

docs/feature_ps2_mouse.md Outdated Show resolved Hide resolved

tmk_core/protocol/ps2_interrupt.c Outdated Show resolved Hide resolved

drashna requested a review from zvecr October 22, 2019 03:44

drashna approved these changes Oct 22, 2019

View reviewed changes

qmk deleted a comment from Ratna04priya Oct 22, 2019

zvecr requested changes Oct 22, 2019

View reviewed changes

tmk_core/protocol/ps2_mouse.c Show resolved Hide resolved

tmk_core/protocol/ps2_interrupt.c Outdated Show resolved Hide resolved

docs/feature_ps2_mouse.md Outdated Show resolved Hide resolved

JohSchneider commented Oct 22, 2019

View reviewed changes

qmk deleted a comment from PrathamGoyal Oct 22, 2019

JohSchneider requested a review from zvecr October 22, 2019 18:16

qmk deleted a comment from raghavdhingra Oct 23, 2019

parammittal16 reviewed Oct 29, 2019

View reviewed changes

drashna added the awaiting review label Oct 30, 2019

qmk deleted a comment from rishav142k Oct 31, 2019

Johannes added 2 commits March 2, 2020 19:03

ps2_mouse on ARM: an interrupt-version of the ps2-mouse code ported t…

2fd626b

…o ARM/chibios

ps2_mouse on ARM: link EXT callback-channel selection to the user def…

c6ece46

…ined PS2_LINE_CLOCK

twadleigh reviewed May 18, 2020

View reviewed changes

tmk_core/protocol/ps2_interrupt.c Show resolved Hide resolved

twadleigh reviewed May 18, 2020

View reviewed changes

tmk_core/protocol/ps2_interrupt.c Show resolved Hide resolved

ps2_mouse: add systemlocks

33f9918

using the chibios equivalent to AVRs cli: chSys[Unl|L]ock

tzarc approved these changes Jul 16, 2020

View reviewed changes

tzarc requested a review from a team July 16, 2020 12:24

tzarc changed the base branch from master to develop July 25, 2020 03:10

noroadsleft force-pushed the develop branch 2 times, most recently from 550bb6a to 9d827f9 Compare July 31, 2020 19:45

noroadsleft force-pushed the develop branch from 7499550 to 8b7b3ce Compare August 11, 2020 08:25

noroadsleft added the needs testing label Aug 14, 2020

noroadsleft force-pushed the develop branch 2 times, most recently from 1d4c0cd to 65c27a3 Compare August 29, 2020 21:42

noroadsleft force-pushed the develop branch from 3a8e1b8 to a1b96ba Compare September 4, 2020 22:03

noroadsleft force-pushed the develop branch from a1b96ba to 3430907 Compare September 12, 2020 11:47

skullydazed force-pushed the develop branch from fa8cf59 to cce70f1 Compare October 18, 2020 21:10

noroadsleft force-pushed the develop branch from 5720202 to dcefc1a Compare October 23, 2020 22:37

skullydazed force-pushed the develop branch from db745a9 to 68fc044 Compare October 28, 2020 02:16

noroadsleft force-pushed the develop branch from 92ca6b9 to c3221d4 Compare October 30, 2020 20:23

noroadsleft closed this Nov 28, 2020

noroadsleft deleted the branch qmk:develop November 28, 2020 20:02

tzarc reopened this Nov 28, 2020

noroadsleft force-pushed the develop branch from 7d3841e to 3cc7d22 Compare November 30, 2020 11:32

tzarc closed this Feb 27, 2021

tzarc deleted the branch qmk:develop February 27, 2021 20:27

noroadsleft reopened this Feb 27, 2021

tzarc merged commit bcb6e23 into qmk:develop Aug 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arm ps2 mouse interrupt #6490

Arm ps2 mouse interrupt #6490

JohSchneider commented Aug 5, 2019

drashna left a comment

JohSchneider commented Aug 6, 2019

zvecr Aug 7, 2019

JohSchneider Aug 8, 2019

zvecr Aug 8, 2019 •

edited

Loading

JohSchneider Aug 9, 2019

This comment was marked as off-topic.

drashna Dec 17, 2020

hugovk left a comment

samagragupta left a comment •

edited by yanfali

Loading

parammittal16 left a comment •

edited by zvecr

Loading

JohSchneider commented May 20, 2020

tzarc left a comment

tzarc commented Jul 25, 2020

Arm ps2 mouse interrupt #6490

Arm ps2 mouse interrupt #6490

Conversation

JohSchneider commented Aug 5, 2019

Description

Types of Changes

drashna left a comment

Choose a reason for hiding this comment

JohSchneider commented Aug 6, 2019

zvecr Aug 7, 2019

Choose a reason for hiding this comment

JohSchneider Aug 8, 2019

Choose a reason for hiding this comment

zvecr Aug 8, 2019 • edited Loading

Choose a reason for hiding this comment

JohSchneider Aug 9, 2019

Choose a reason for hiding this comment

This comment was marked as off-topic.

drashna Dec 17, 2020

Choose a reason for hiding this comment

hugovk left a comment

Choose a reason for hiding this comment

samagragupta left a comment • edited by yanfali Loading

Choose a reason for hiding this comment

parammittal16 left a comment • edited by zvecr Loading

Choose a reason for hiding this comment

JohSchneider commented May 20, 2020

tzarc left a comment

Choose a reason for hiding this comment

tzarc commented Jul 25, 2020

zvecr Aug 8, 2019 •

edited

Loading

samagragupta left a comment •

edited by yanfali

Loading

parammittal16 left a comment •

edited by zvecr

Loading