Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with RGB Matrix Sleeping #6556

Closed
wants to merge 1 commit into from
Closed

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 17, 2019

For some reason, occasionally it renders some of the lights still. This is most likely a timing issue since the matrix render is set up to do batch updates. It just doesn't stop in time, so the simple solution is to clear all of them.

Types of Changes

  • Bugfix

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

For some reason, occasionally it renders some of the lights still. This is most likely a timing issue since the matrix render is set up to do batch updates. It just doesn't stop in time, so the simple solution is to clear all of them.
@drashna drashna added the bug label Aug 17, 2019
@drashna drashna requested a review from a team August 17, 2019 02:31
@drashna
Copy link
Member Author

drashna commented Aug 17, 2019

#6480 fixes the same issue, and in a better way, plus more. Closing this one.

@drashna drashna closed this Aug 17, 2019
@drashna drashna deleted the fix/rgb_matrix_suspend branch August 17, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant