Update ChibiOS Contrib module #6826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
added
breaking_change
|
Meant to open as draft ... |
yanfali
approved these changes
Sep 28, 2019
|
Oof 220+ commits to review |
|
Yeah .... We should be more aggressive about maintaining these. But at least the breaking changes stuff gives us a good way to manage this, and an excuse to do so. Just wish that updating chibiOS was as easy. |
drashna
force-pushed
the
update_chibios-contrib
branch
from
026390b
to
ae38df0
Compare
drashna
commented
Dec 1, 2019
| @@ -3,8 +3,7 @@ | |||
| url = https://github.com/qmk/ChibiOS | |||
| [submodule "lib/chibios-contrib"] | |||
| path = lib/chibios-contrib | |||
| url = https://github.com/qmk/ChibiOS-Contrib | |||
| branch = k-type-fix | |||
| url = https://github.com/drashna/ChibiOS-Contrib | |||
There was a problem hiding this comment.
This should/will be changed back to QMK's fork once qmk/ChibiOS-Contrib#12 has been merged in.
Right now, this is pointing at my repo, since it's "up to date"
|
This requires chibiOS to be updated, as well.... At least for the K12 and K20 MCUs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ChibiOS Contrib submodule to the latest version. This contains the k type fix, as that was merged upstream.
This should be reset back to the qmk fork, once it's updated.
Additionally, we may want to wait on qmk/ChibiOS-Contrib#10 getting merged (to upstream, even).