Fix small hiccup in snake animation #6858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Oct 2, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Oct 31, 2019
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Nov 4, 2019
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Dec 6, 2019
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's an occasional 'lag' frame of animation or two when using the 'snake' RGB animation when the 'snake' reaches the last LEDs. This small fix just corrects that issue (it will no longer try to set LEDs that don't exist).
Types of Changes
Issues Fixed or Closed by This PR
Checklist