Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add personal keymaps #6875

Merged
merged 34 commits into from
Oct 16, 2019
Merged

[WIP] Add personal keymaps #6875

merged 34 commits into from
Oct 16, 2019

Conversation

Endemoniada
Copy link
Contributor

Description

Add my own personal keymaps and layouts. They contain a fair bit of ASCII keyboard art that some might find useful.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the keymap label Oct 2, 2019
@drashna drashna requested a review from a team October 2, 2019 16:15
keyboards/dz60/keymaps/mekberg/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/mekberg/keymap.c Outdated Show resolved Hide resolved
keyboards/tada68/keymaps/mekberg/keymap.c Outdated Show resolved Hide resolved
keyboards/tada68/keymaps/mekberg/rules.mk Show resolved Hide resolved
@fauxpark
Copy link
Member

fauxpark commented Oct 3, 2019

Also, your rules.mk for the Let's Split can be deleted, it's not required to be present for keymaps.

@Endemoniada
Copy link
Contributor Author

@fauxpark Thanks for all the excellent feedback! :)

keyboards/lets_split/keymaps/mekberg/keymap.c Outdated Show resolved Hide resolved
keyboards/tada68/keymaps/mekberg/keymap.c Outdated Show resolved Hide resolved
@noroadsleft
Copy link
Member

@Endemoniada Everything looks okay here to me. Let us know when you're ready for this to be merged.

@Endemoniada
Copy link
Contributor Author

@Endemoniada Everything looks okay here to me. Let us know when you're ready for this to be merged.

Awesome, thanks. Go ahead and merge :)

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@drashna drashna merged commit 7677e8a into qmk:master Oct 16, 2019
@Endemoniada Endemoniada deleted the feature/mekberg branch October 17, 2019 06:29
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* Add dz60 keymap

* Add my TADA68 layout

* Fix descriptions and formatting

* Formatting fixes

* Add readme file

* Formatting

* move caps lock to correct key, add F-keys to both layers

* Add readme for dz60

* First draft of custom Let's Split layout

* Some more keys

* Finalized keymap

* Added a bunch of custom shortcuts to make layout easier to read

* Add PERMISSIVE_HOLD option to modtap behavior

* Add lock and sleep shortcuts, formatting

* Minor fixes and adjustments

* Add PERMISSIVE_HOLD option, add sleep/lock shortcuts, minor fixes

* Add sleep/lock shortcuts, minor fixes

* fixups

* Major simplification of lets_split layout into more standard raise/lower/special layers

* Remove layer songs, add to readme

* Formatting

* Switch a few keys around for reachability

* Add windows/mac specific layers

* simplify layers

* Update README

* Fix legends

* Invert numpad and put Del in upper right corner

* Disable arrow keys on Raise, add build instructions

* Move dz60 keymap to its own branch

* Remove redundant configuration

* Change volume and sleep keycodes to standard

* Removing empty rules.mk

* Changing layer defines to enum

* Adding comment to explain reason for swapping KC_TRNS and KC_NO fillers
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* Add dz60 keymap

* Add my TADA68 layout

* Fix descriptions and formatting

* Formatting fixes

* Add readme file

* Formatting

* move caps lock to correct key, add F-keys to both layers

* Add readme for dz60

* First draft of custom Let's Split layout

* Some more keys

* Finalized keymap

* Added a bunch of custom shortcuts to make layout easier to read

* Add PERMISSIVE_HOLD option to modtap behavior

* Add lock and sleep shortcuts, formatting

* Minor fixes and adjustments

* Add PERMISSIVE_HOLD option, add sleep/lock shortcuts, minor fixes

* Add sleep/lock shortcuts, minor fixes

* fixups

* Major simplification of lets_split layout into more standard raise/lower/special layers

* Remove layer songs, add to readme

* Formatting

* Switch a few keys around for reachability

* Add windows/mac specific layers

* simplify layers

* Update README

* Fix legends

* Invert numpad and put Del in upper right corner

* Disable arrow keys on Raise, add build instructions

* Move dz60 keymap to its own branch

* Remove redundant configuration

* Change volume and sleep keycodes to standard

* Removing empty rules.mk

* Changing layer defines to enum

* Adding comment to explain reason for swapping KC_TRNS and KC_NO fillers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants