Add python-pip as package dependency for archlinux #7041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
reviewed
Oct 15, 2019
rishav142k
reviewed
Oct 15, 2019
There was a problem hiding this comment.
Doing a sudo pip is not recommended and is considered a bad practice. It is a lot security risk to do so as it gives root privileges while PyPi installer packages.One can use sudo with apt but not with pip. sudo pip overwrites python content provided by our OS vendor.
|
It turns out all the python requirements already are included in archlinux official repositories. "pacman -S --needed python-appdirs python-argcomplete python-colorama" will solve the issue for archlinux. |
drashna
approved these changes
Oct 16, 2019
fauxpark
reviewed
Oct 16, 2019
|
@fauxpark , I understand your point now. and using pip install --user as requirements manager for python in install_linux.sh. |
fauxpark
approved these changes
Oct 18, 2019
drashna
approved these changes
Oct 19, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Oct 31, 2019
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Nov 4, 2019
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Dec 6, 2019
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to "pip3 install" failed in script linux_install.sh. python-pip has been added as package dependency for archlinux.
Types of Changes
Issues Fixed or Closed by This PR
#7040
*
Checklist