Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Move vitamins included rev1 to split_common #7052

Merged
merged 2 commits into from
Oct 17, 2019
Merged

[Keyboard] Move vitamins included rev1 to split_common #7052

merged 2 commits into from
Oct 17, 2019

Conversation

Duckle29
Copy link
Contributor

Thanks to the great work by @zvecr in #6424, I can now move rev1 to split_common. This PR does so

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 16, 2019 19:30
@zvecr zvecr merged commit 550435c into qmk:master Oct 17, 2019
@zvecr
Copy link
Member

zvecr commented Oct 17, 2019

Thanks!

@Duckle29 Duckle29 deleted the vita-inc_v1_split-common branch October 17, 2019 19:03
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@Duckle29
[Keyboard] Move vitamins included rev1 to split_common (qmk#7052)
6eaf935 
* Initial work to move to split_common

* Fixed serial pin
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Duckle29 @HokieGeek
[Keyboard] Move vitamins included rev1 to split_common (qmk#7052)
a320f70 
* Initial work to move to split_common

* Fixed serial pin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Duckle29 @zvecr @drashna @fauxpark