-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keymap] Romain's Preonic layout #7067
Conversation
Co-Authored-By: fauxpark <fauxpark@gmail.com>
I implemented the changes suggested. Thanks for your review @fauxpark ! |
A question for the knowledgeable(s): should I keep the I first tried to remove it before seeing that – oh surprise – the lower layer became the default layer and I fixed it by making the enum values start at 1 but I don't know if it was the right thing to do. |
Yes. |
Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>
OK, it's done. I think it's as lean as I can make it, thanks for the reviews @fauxpark, @drashna & @noroadsleft ! If you see anything that can be further improved, just let me know. (And also if you have ideas for the key 2nd row from the top, 1st column from the right) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
* Add customized preonic layout * Add a README detailing a bit the differences from the default preonic layout * Apply suggestions from code review Co-Authored-By: fauxpark <fauxpark@gmail.com> * Remove unnecessary end-of-line backslashes * Import fix for startup sound (thanks @drashna) * Remove unnecessary layers and keycodes * Bring back the _QWERTY layer code Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>
* Add customized preonic layout * Add a README detailing a bit the differences from the default preonic layout * Apply suggestions from code review Co-Authored-By: fauxpark <fauxpark@gmail.com> * Remove unnecessary end-of-line backslashes * Import fix for startup sound (thanks @drashna) * Remove unnecessary layers and keycodes * Bring back the _QWERTY layer code Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>
Description
Add the keymap I use daily. There are more info about this mapping in the README.
Types of Changes
Issues Fixed or Closed by This PR
Checklist