Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GPIO macros for E6 LED in Planck and Preonic default keymaps #7098

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Use GPIO macros for E6 LED in Planck and Preonic default keymaps #7098

merged 1 commit into from
Oct 21, 2019

Conversation

fauxpark
Copy link
Member

Description

😄

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 21, 2019 00:36
@fauxpark fauxpark mentioned this pull request Oct 21, 2019
Merged
13 tasks
@noroadsleft
Copy link
Member

Thanks!

@noroadsleft noroadsleft merged commit 97b8ade into qmk:master Oct 21, 2019
This was referenced Oct 21, 2019
Merged
Merged
Merged
@fauxpark fauxpark deleted the planck-preonic-gpio-commands branch October 21, 2019 06:19
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@fauxpark
[Keyboard] Use GPIO macros for E6 LED in Planck and Preonic default k…
e308448 
…eymaps (qmk#7098)
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@fauxpark @HokieGeek
[Keyboard] Use GPIO macros for E6 LED in Planck and Preonic default k…
442ae59 
…eymaps (qmk#7098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

@jackhumbert jackhumbert jackhumbert approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @noroadsleft @jackhumbert @drashna