Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new PCB Hannah910 #7234

Merged
merged 3 commits into from
Nov 2, 2019
Merged

Add new PCB Hannah910 #7234

merged 3 commits into from
Nov 2, 2019

Conversation

mechlovin
Copy link
Contributor

a replace pcb for tgr910 keyboard

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@vuhopkep
Add new PCB Hannah910
0d515e3 
a replace pcb for tgr910 keyboard
noroadsleft
noroadsleft requested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, keyboards/mechlovin/hannah910/info.json has a split Backspace for LAYOUT_iso, but a 2u Backspace for LAYOUT_ansi. There's nothing "wrong" with that per se, but I wanted to make sure that was a deliberate decision.

keyboards/mechlovin/hannah910/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rules.mk Outdated Show resolved Hide resolved
noroadsleft
noroadsleft approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

drashna
drashna approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drashna drashna merged commit f5cf5b9 into qmk:master Nov 2, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@mechlovin
[Keyboard] Add Hannah910 (qmk#7234)
03e6be9 
* Add new PCB Hannah910

a replace pcb for tgr910 keyboard

* Update readme.md

* update
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@mechlovin @patrl
[Keyboard] Add Hannah910 (qmk#7234)
eddccc1 
* Add new PCB Hannah910

a replace pcb for tgr910 keyboard

* Update readme.md

* update
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@mechlovin @HokieGeek
[Keyboard] Add Hannah910 (qmk#7234)
121ea55 
* Add new PCB Hannah910

a replace pcb for tgr910 keyboard

* Update readme.md

* update
@mechlovin mechlovin mentioned this pull request Sep 3, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mechlovin @drashna @noroadsleft @mechmerlin @vuhopkep