-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process leader mappings on key press #7270
Conversation
quantum/quantum.c
Outdated
@@ -982,6 +982,10 @@ void matrix_scan_quantum() { | |||
matrix_scan_combo(); | |||
#endif | |||
|
|||
#if defined(LEADER_ENABLE) && defined(LEADER_ON_KEY_PROCESSING) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could just use:
#if defined(LEADER_ENABLE) && defined(LEADER_ON_KEY_PROCESSING) | |
#if defined(LEADER_ENABLE) |
If not, it would be nice ideal if things could be changed so this is called in such a way that it could be use regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would break existing code because calling matrix_scan_leader()
when on key processing is not enabled would finish the leader mode before the user gets the chance to catch it in his matrix_scan_user()
with the usual LEADER_DICTIONARY()
method.
However, we could move the check to into matrix_scan_leader()
to keep the matrix function cleaner.
Otherwise it would break existing code that uses a leader sequence that contains KC_LEAD
Thank you for your contribution! |
Thank you for your contribution! |
Thank you for your contribution! |
Description
This PR has similar goals as #6580 but uses a different approach.
LEADER_PER_KEY_TIMING
but you don't have to wait for the timeout to happen.LEADER_TIMEOUT
KC_LEAD
LEADER_EXTERNS
andLEADER_DICTIONARY
in user codeHere's an example for a user function:
Types of Changes
Issues Fixed or Closed by This PR
Checklist