Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keymap] Add abnt2 format to gh60 #7371

Merged
merged 11 commits into from
Nov 18, 2019

Conversation

luizcorreia
Copy link
Contributor

Added brazilian abnt2 format to gh60

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@luizcorreia luizcorreia requested a review from drashna November 15, 2019 23:28
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a lot of these ABNT2 support pull requests planned, we could add it as a Community Layout. Though that doesn't do anything with any LED indicators that may be present on the hardware.

keyboards/dz60/keymaps/default_abnt2/readme.md Outdated Show resolved Hide resolved
keyboards/gh60/revc/info.json Outdated Show resolved Hide resolved
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@luizcorreia
Copy link
Contributor Author

@noroadsleft The abnt2 format is the default used on all keyboards in Brazil, it differs from iso in having one more key splinting the right shift.
I didn't quite understand the community layout.

@noroadsleft
Copy link
Member

@luizcorreia,

Community Layouts is a feature in QMK Firmware that allows a user to write one keymap that can be used on multiple keyboards, if the user owns multiple keyboards that share the same physical layout, such as owning a DZ60, a GH60 rev. C and a Zeal60, all built with a standard ANSI layout.

Instead of having something like a luizcorreia keymap in each of keyboards/dz60/, keyboards/gh60/revc/ and keyboards/zeal60/, you could write one keymap.c that goes in layouts/community/60_abnt2/luizcorreia/ and use that with any keyboard that's configured to support the 60_abnt2 layout.

@luizcorreia
Copy link
Contributor Author

@luizcorreia,

Community Layouts is a feature in QMK Firmware that allows a user to write one keymap that can be used on multiple keyboards, if the user owns multiple keyboards that share the same physical layout, such as owning a DZ60, a GH60 rev. C and a Zeal60, all built with a standard ANSI layout.

Instead of having something like a luizcorreia keymap in each of keyboards/dz60/, keyboards/gh60/revc/ and keyboards/zeal60/, you could write one keymap.c that goes in layouts/community/60_abnt2/luizcorreia/ and use that with any keyboard that's configured to support the 60_abnt2 layout.

I see, but I don't want a layout with my name, I want help people in Brazil, that want a keyboard with abnt2 format. I will make a community layout in this PR or create another?

@noroadsleft
Copy link
Member

I see, but I don't want a layout with my name, I want help people in Brazil, that want a keyboard with abnt2 format. I will make a community layout in this PR or create another?

It would be done in another PR. I could actually define the Community Layout, which would dictate the order any supporting keyboards would need to use, though the keyboards would still need to be modified as you've done here.

I'll make a PR and tag you so you can see what I'm talking about.

@luizcorreia
Copy link
Contributor Author

I see, but I don't want a layout with my name, I want help people in Brazil, that want a keyboard with abnt2 format. I will make a community layout in this PR or create another?

It would be done in another PR. I could actually define the Community Layout, which would dictate the order any supporting keyboards would need to use, though the keyboards would still need to be modified as you've done here.

I'll make a PR and tag you so you can see what I'm talking about.

@noroadsleft Will you approve this PR? What a need to do?

@noroadsleft noroadsleft added configurator affects configurator keyboard labels Nov 17, 2019
@noroadsleft
Copy link
Member

I found an issue yesterday with the existing info.json file while working on something else entirely – not your fault, @luizcorreia – so I need to go through the info.json file anyway to check it.

@noroadsleft
Copy link
Member

Thanks!

@noroadsleft noroadsleft merged commit e58dd1a into qmk:master Nov 18, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* [keymap] Add abnt2 format to gh60

* Fix typing errors

* Change key names to capitals

* Fix layout define

* Apply suggestions from code review

* Fix layout define again I used a k

* Remove layer variable

* Update keyboards/dz60/keymaps/default_abnt2/readme.md

* Make changes from noroadsleft
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
* [keymap] Add abnt2 format to gh60

* Fix typing errors

* Change key names to capitals

* Fix layout define

* Apply suggestions from code review

* Fix layout define again I used a k

* Remove layer variable

* Update keyboards/dz60/keymaps/default_abnt2/readme.md

* Make changes from noroadsleft
@noroadsleft noroadsleft removed the configurator affects configurator label Jan 15, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* [keymap] Add abnt2 format to gh60

* Fix typing errors

* Change key names to capitals

* Fix layout define

* Apply suggestions from code review

* Fix layout define again I used a k

* Remove layer variable

* Update keyboards/dz60/keymaps/default_abnt2/readme.md

* Make changes from noroadsleft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants