-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keymap] Add abnt2 format to gh60 #7371
[keymap] Add abnt2 format to gh60 #7371
Conversation
Co-Authored-By: Drashna Jaelre <drashna@live.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a lot of these ABNT2 support pull requests planned, we could add it as a Community Layout. Though that doesn't do anything with any LED indicators that may be present on the hardware.
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft The abnt2 format is the default used on all keyboards in Brazil, it differs from iso in having one more key splinting the right shift. |
…mk_firmware into feature/default_abnt2_gh60
Community Layouts is a feature in QMK Firmware that allows a user to write one keymap that can be used on multiple keyboards, if the user owns multiple keyboards that share the same physical layout, such as owning a DZ60, a GH60 rev. C and a Zeal60, all built with a standard ANSI layout. Instead of having something like a |
I see, but I don't want a layout with my name, I want help people in Brazil, that want a keyboard with abnt2 format. I will make a community layout in this PR or create another? |
It would be done in another PR. I could actually define the Community Layout, which would dictate the order any supporting keyboards would need to use, though the keyboards would still need to be modified as you've done here. I'll make a PR and tag you so you can see what I'm talking about. |
@noroadsleft Will you approve this PR? What a need to do? |
I found an issue yesterday with the existing |
Thanks! |
* [keymap] Add abnt2 format to gh60 * Fix typing errors * Change key names to capitals * Fix layout define * Apply suggestions from code review * Fix layout define again I used a k * Remove layer variable * Update keyboards/dz60/keymaps/default_abnt2/readme.md * Make changes from noroadsleft
* [keymap] Add abnt2 format to gh60 * Fix typing errors * Change key names to capitals * Fix layout define * Apply suggestions from code review * Fix layout define again I used a k * Remove layer variable * Update keyboards/dz60/keymaps/default_abnt2/readme.md * Make changes from noroadsleft
* [keymap] Add abnt2 format to gh60 * Fix typing errors * Change key names to capitals * Fix layout define * Apply suggestions from code review * Fix layout define again I used a k * Remove layer variable * Update keyboards/dz60/keymaps/default_abnt2/readme.md * Make changes from noroadsleft
Added brazilian abnt2 format to gh60
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist