Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define new keyboard "thedogkeyboard" #7401

Merged
merged 9 commits into from
Nov 20, 2019
Merged

define new keyboard "thedogkeyboard" #7401

merged 9 commits into from
Nov 20, 2019

Conversation

kakunpc
Copy link
Contributor

@kakunpc kakunpc commented Nov 18, 2019

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 18, 2019 17:02
noroadsleft
noroadsleft requested changes Nov 18, 2019
View reviewed changes
keyboards/thedogkeyboard/readme.md Outdated Show resolved Hide resolved
keyboards/thedogkeyboard/readme.md Outdated Show resolved Hide resolved
keyboards/thedogkeyboard/readme.md Outdated Show resolved Hide resolved
keyboards/thedogkeyboard/readme.md Outdated Show resolved Hide resolved
keyboards/thedogkeyboard/rules.mk Outdated Show resolved Hide resolved
keyboards/thedogkeyboard/thedogkeyboard.h Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Nov 18, 2019
View reviewed changes
keyboards/thedogkeyboard/keymaps/default/config.h Outdated
@@ -0,0 +1,19 @@
/* Copyright 2019 kakunpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be deleted.

keyboards/thedogkeyboard/keymaps/kakunpc/config.h Outdated
@@ -0,0 +1,19 @@
/* Copyright 2019 kakunpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be deleted.

keyboards/thedogkeyboard/keymaps/kakunpc/keymap.c Outdated
Comment on lines 45 to 55
void matrix_init_user(void) {
}

void matrix_scan_user(void) {

}

void led_set_user(uint8_t usb_led) {

}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions can be removed.

keyboards/thedogkeyboard/thedogkeyboard.c Outdated
Comment on lines 18 to 51
// Optional override functions below.
// You can leave any or all of these undefined.
// These are only required if you want to perform custom actions.

/*

void matrix_init_kb(void) {
// put your keyboard start-up code here
// runs once when the firmware starts up

matrix_init_user();
}

void matrix_scan_kb(void) {
// put your looping keyboard code here
// runs every cycle (a lot)

matrix_scan_user();
}

bool process_record_kb(uint16_t keycode, keyrecord_t *record) {
// put your per-action keyboard code here
// runs for every action, just before processing by the firmware

return process_record_user(keycode, record);
}

void led_set_kb(uint8_t usb_led) {
// put your keyboard LED indicator (ex: Caps Lock LED) toggling code here

led_set_user(usb_led);
}

*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this can be deleted.

keyboards/thedogkeyboard/matrix.c Show resolved Hide resolved
kakunpc and others added 5 commits November 19, 2019 12:13
@kakunpc @noroadsleft
Update keyboards/thedogkeyboard/readme.md
3927909 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@kakunpc @noroadsleft
Update keyboards/thedogkeyboard/readme.md
9b6efcd 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@kakunpc @noroadsleft
Update keyboards/thedogkeyboard/readme.md
4c2a80a 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@kakunpc @noroadsleft
Update keyboards/thedogkeyboard/readme.md
a6dd29d 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@kakunpc
update thedogkeyboard
1b32f74
@kakunpc
Copy link
Contributor Author

kakunpc commented Nov 19, 2019

Thank you for the code review.
I fixed that as it was pointed out to me.

noroadsleft
noroadsleft approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Duckle29
Duckle29 approved these changes Nov 19, 2019
View reviewed changes
keyboards/thedogkeyboard/config.h Show resolved Hide resolved
@drashna drashna merged commit 46606e1 into qmk:master Nov 20, 2019
@kakunpc kakunpc deleted the kakunpc/add_thedogkeyboard branch November 22, 2019 03:24
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@kakunpc
[Keyboard] Add "thedogkeyboard" (qmk#7401)
a58be7c 
* add the dog keyboard

* set rgbled

* fix info.json and readme.md

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* update thedogkeyboard
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@kakunpc @patrl
[Keyboard] Add "thedogkeyboard" (qmk#7401)
0bf71bf 
* add the dog keyboard

* set rgbled

* fix info.json and readme.md

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* update thedogkeyboard
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@kakunpc @HokieGeek
[Keyboard] Add "thedogkeyboard" (qmk#7401)
5300462 
* add the dog keyboard

* set rgbled

* fix info.json and readme.md

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update keyboards/thedogkeyboard/readme.md

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* update thedogkeyboard
@elfmimi elfmimi mentioned this pull request Mar 2, 2020
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@Duckle29 Duckle29 Duckle29 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kakunpc @drashna @Duckle29 @fauxpark @noroadsleft