Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yet another dictionary for the QMK Firmware docs sidebar heading #7504

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

fauxpark
Copy link
Member

Description

Without this, clicking on the sidebar heading while browsing in another language takes you back to the English landing page.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 28, 2019 11:36
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zvecr zvecr merged commit 7164e8e into qmk:master Nov 28, 2019
@fauxpark fauxpark deleted the docs-namelink-langs branch November 28, 2019 22:15
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants