Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed I2C driver support for stm32f4 #7526

Merged
merged 3 commits into from
Dec 13, 2019
Merged

fixed I2C driver support for stm32f4 #7526

merged 3 commits into from
Dec 13, 2019

Conversation

yulei
Copy link
Contributor

@yulei yulei commented Dec 2, 2019 •
edited by drashna
Loading

stm32f4 uses I2Cv1 and GPIOv2 drivers, so the current definitions on i2c_master.h should be modified.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 2, 2019 04:09
zvecr
zvecr requested changes Dec 2, 2019
View reviewed changes
drivers/arm/i2c_master.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 2, 2019 19:07
zvecr
zvecr requested changes Dec 3, 2019
View reviewed changes
drivers/arm/i2c_master.h Outdated Show resolved Hide resolved
@zvecr zvecr mentioned this pull request Dec 8, 2019
Merged
13 tasks
@yulei yulei mentioned this pull request Dec 9, 2019
Closed
4 tasks
@zvecr zvecr mentioned this pull request Dec 9, 2019
Merged
13 tasks
@drashna drashna merged commit a037ced into qmk:master Dec 13, 2019
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@yulei @patrl
fixed I2C driver support for stm32f4 (qmk#7526)
df8c7b0 
* correct i2c driver for stm32f4

* update pin mode definitions

* update macro definition
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 2, 2020
@yulei @drashna
fixed I2C driver support for stm32f4 (qmk#7526)
41bdb6c 
* correct i2c driver for stm32f4

* update pin mode definitions

* update macro definition
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 6, 2020
@yulei @fdidron
fixed I2C driver support for stm32f4 (qmk#7526)
1becd06 
* correct i2c driver for stm32f4

* update pin mode definitions

* update macro definition
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 8, 2020
@yulei @fdidron
fixed I2C driver support for stm32f4 (qmk#7526)
5f9e60b 
* correct i2c driver for stm32f4

* update pin mode definitions

* update macro definition
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@yulei @HokieGeek
fixed I2C driver support for stm32f4 (qmk#7526)
41e72b5 
* correct i2c driver for stm32f4

* update pin mode definitions

* update macro definition
@yulei yulei deleted the i2ddef branch March 11, 2020 08:29
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@yulei @drashna
fixed I2C driver support for stm32f4 (qmk#7526)
fa21b7a 
* correct i2c driver for stm32f4

* update pin mode definitions

* update macro definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't compile Chibios I2CV1 driver under stm32f4 through QMK configurator
4 participants
@yulei @drashna @fauxpark @zvecr