Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate rgblight and backlight task #7733

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 29, 2019

Description

Backlight with CTPC wasnt happy on arm_split, where it would only function on the master slide. While moving backlight_task, rgblight_task also looked out of place at the protocol level so that was moved too.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team December 29, 2019 01:16
@drashna drashna requested a review from a team December 29, 2019 01:36
@zvecr zvecr force-pushed the feature/task_align branch from 4426c6d to bca857a Compare January 13, 2020 01:35
@zvecr zvecr marked this pull request as ready for review January 13, 2020 01:35
@zvecr
Copy link
Member Author

zvecr commented Jan 13, 2020

Rebased now #7273 has been merged

@drashna drashna requested review from skullydazed and a team January 13, 2020 18:09
@zvecr zvecr merged commit ba628a2 into qmk:master Jan 19, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 12, 2020
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 14, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 26, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@zvecr zvecr deleted the feature/task_align branch April 28, 2020 01:12
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants