Added mverteuil keymaps and userspace common code #7876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
reviewed
Jan 13, 2020
|
Thanks for all of the great feedback, I will integrate your changes and push shortly! ❤️ 👍 |
fauxpark
requested changes
Jan 14, 2020
mverteuil
force-pushed
the
mverteuil
branch
3 times, most recently
from
dce273d to
365ad91
Compare
mverteuil
force-pushed
the
mverteuil
branch
5 times, most recently
from
5f54df3 to
299d25b
Compare
|
@fauxpark I've implemented your requests, thanks for the tips! |
fauxpark
requested changes
Jan 14, 2020
drashna
reviewed
Jan 15, 2020
- Userspace - Knops keymap - Preonic keymaps
|
By the way, you don't need to keep force-pushing - we squash all PRs anyway. |
Fair enough, just a force of habit because it's easier to rebase off master on other projects when I remove fixup commits ;) |
|
Ok I think this should be good for review again |
drashna
reviewed
Jan 18, 2020
drashna
approved these changes
Jan 18, 2020
fauxpark
approved these changes
Jan 18, 2020
|
Thanks again for all the help and feedback y'all 💟 |
|
Thanks for contributing! |
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* Added mverteuil content - Userspace - Knops keymap - Preonic keymaps * Simplified and replaced some magic numbers * Convert tabs to spaces * Clean up LED handling, better animation, better layer init * Use get_highest_layer per @drashna suggestion * Reorder prototypes/reformat * Simplified/more expessive and fixed initial layer LED * Remove changes to git ignored files
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Added mverteuil content - Userspace - Knops keymap - Preonic keymaps * Simplified and replaced some magic numbers * Convert tabs to spaces * Clean up LED handling, better animation, better layer init * Use get_highest_layer per @drashna suggestion * Reorder prototypes/reformat * Simplified/more expessive and fixed initial layer LED * Remove changes to git ignored files
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Added mverteuil content - Userspace - Knops keymap - Preonic keymaps * Simplified and replaced some magic numbers * Convert tabs to spaces * Clean up LED handling, better animation, better layer init * Use get_highest_layer per @drashna suggestion * Reorder prototypes/reformat * Simplified/more expessive and fixed initial layer LED * Remove changes to git ignored files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds keymap/userspace
Types of Changes
Issues Fixed or Closed by This PR
N/A
Checklist