[Keyboard] Use DIRECT_PINS instead of empty MATRIX_ROW_PINS: sixshooter #8130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
You could map the direct pins more like the physical layout like:
https://github.com/qmk/qmk_firmware/blob/master/keyboards/keebio/bdn9/config.h#L35 and https://github.com/qmk/qmk_firmware/blob/master/keyboards/keebio/bdn9/bdn9.h#L28
|
I don’t think that’s necessary when there is only a single row. |
The single row way was a hangover from before DIRECT_PINS existed. |
|
I got what you mean. |
ridingqwerty
approved these changes
Feb 10, 2020
drashna
approved these changes
Feb 11, 2020
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
…er (qmk#8130) * [Keyboard] Use DIRECT_PINS instead of empty MATRIX_ROW_PINS: sixshooter * [Keyboard] Reform the matrix into 2x3: sixshooter
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
…er (qmk#8130) * [Keyboard] Use DIRECT_PINS instead of empty MATRIX_ROW_PINS: sixshooter * [Keyboard] Reform the matrix into 2x3: sixshooter
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…er (qmk#8130) * [Keyboard] Use DIRECT_PINS instead of empty MATRIX_ROW_PINS: sixshooter * [Keyboard] Reform the matrix into 2x3: sixshooter
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
…er (qmk#8130) * [Keyboard] Use DIRECT_PINS instead of empty MATRIX_ROW_PINS: sixshooter * [Keyboard] Reform the matrix into 2x3: sixshooter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the config.h of sixshooter, it has been defined as following.
#define MATRIX_ROWS 1
#define MATRIX_ROW_PINS { }
This is a potential bug because by definition row_pins will get assigned undefined value.
In this case use of DIRECT_PINS is appropriate.
Similar to #8115, I need this consistency for my next PR.
Types of Changes
Checklist