Tweak my TAPPING_TERM and be more futureproof #8143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Feb 11, 2020
fauxpark
approved these changes
Feb 11, 2020
|
Thanks! |
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* Explicitly undef things I override in keymaps * Reduce TAPPING_TERM back to default
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
* Explicitly undef things I override in keymaps * Reduce TAPPING_TERM back to default
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Explicitly undef things I override in keymaps * Reduce TAPPING_TERM back to default
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
* Explicitly undef things I override in keymaps * Reduce TAPPING_TERM back to default
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Explicitly undef things I override in keymaps * Reduce TAPPING_TERM back to default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm reducing my
TAPPING_TERMback to the default (200 ms) to try and combat spurious Esc keypresses on an Esc (tap)/Ctrl (hold) key. It turns out my real issue before was the Lily58 keyboard sets it to super short (100 ms) by default. :) I'm also explicitly#undefing some symbols I redefine in keymap configs so I don't cause problems if the keyboards start defining those things in the future (e.g., #7754).Types of Changes
Issues Fixed or Closed by This PR
None
Checklist