Unconditionally enable ChibiOS syscalls #8268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Whoops, just realised I just included similar changes into a new PR of mine: #8272 |
zvecr
force-pushed
the
feature/syscalls
branch
from
ff45a38 to
94e1093
Compare
tzarc
approved these changes
Feb 29, 2020
|
Currently in the process of rebasing everything.... including all the non PRed stuff ive been sat on for the last couple of months. This should be good to go now. |
|
Yep, all good, go for merge! |
|
I'd been using these in some shape or form for a few months now, too. |
cmaier
pushed a commit
to cmaier/qmk_firmware
that referenced
this pull request
Mar 1, 2020
* Enable syscalls all the time * fix whitespace
rhruiz
pushed a commit
to rhruiz/qmk_firmware
that referenced
this pull request
Mar 1, 2020
* Enable syscalls all the time * fix whitespace
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Mar 5, 2020
* Enable syscalls all the time * fix whitespace
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
* Enable syscalls all the time * fix whitespace
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Mar 26, 2020
* Enable syscalls all the time * fix whitespace
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
Apr 2, 2020
* Enable syscalls all the time * fix whitespace
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Enable syscalls all the time * fix whitespace
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
* Enable syscalls all the time * fix whitespace
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Enable syscalls all the time * fix whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As ChibiOS syscalls is already used within in a few scenarios, this enables by default so that we avoid some of the issues within #7059.
Been using this for a while now and not seen issues 🤷♂️, but then we only alloc in limited circumstances ( otherwise a lot more builds would be failing).
Types of Changes
Issues Fixed or Closed by This PR
make 1upkeyboards/sweet16/v2/proton_c:switchtesterChecklist