Refactor more backlight to a common location #8292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
approved these changes
Mar 3, 2020
nooges
approved these changes
Mar 3, 2020
13 tasks
fauxpark
approved these changes
Mar 3, 2020
drashna
approved these changes
Mar 4, 2020
|
Looks like this breaks Making clueboard/66/rev4 with keymap default [ERRORS]
quantum/backlight/backlight.c:44:36: error: 'BACKLIGHT_PIN' undeclared here (not in a function)
static const pin_t backlight_pin = BACKLIGHT_PIN;
^~~~~~~~~~~~~
|
|
|
make[1]: *** [tmk_core/rules.mk:377: .build/obj_clueboard_66_rev4_default/quantum/backlight/backlight.o] Error 1 |
zvecr
force-pushed
the
feature/more_backlight_common
branch
from
28cb2c4 to
6e341cc
Compare
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
Apr 2, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Apr 10, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 12, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Refactor more backlight to a common location * BACKLIGHT_PIN not defined for custom backlight * align function names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make something like #8291 not introduce a 3rd duplicate copy of some backlight functionality, this PR aims to move more backlight logic to a common location.
Types of Changes
Checklist