[Keymap] planck layout for kifinnsson

[kifinnsson]

Description

My daily driver layout with placeholder cases in process_record_user() for my work macros.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[noroadsleft]

I suspect there may be a more efficient way to do your macros, but it's hard to say at this point because there's no functionality written for them yet.

[kifinnsson]

I'm sure there is it's mostly for my own readability to be honest. They tend to be simple SEND_STRINGS()

…

On Fri, Mar 6, 2020, 12:53 PM James Young ***@***.***> wrote: ***@***.**** requested changes on this pull request. I suspect there may be a more efficient way to do your macros, but it's hard to say at this point because there's no functionality written for them yet. ------------------------------ In keyboards/planck/keymaps/kifinnsson/keymap.c <#8324 (comment)>: > + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + */ + +#include QMK_KEYBOARD_H +#include "muse.h" + +bool is_lgui_active = false; +uint16_t lgui_timer = 0; + +extern keymap_config_t keymap_config; ⬇️ Suggested change -extern keymap_config_t keymap_config; ------------------------------ In keyboards/planck/keymaps/kifinnsson/keymap.c <#8324 (comment)>: > + ), + + /* Extend + * ,-----------------------------------------------------------------------------------. + * | | Esc | WH_U | WBAK | WFWD | MS_U | PgUp | Home | Up | End | Del | Esc | + * |------+------+------+------+------+------+------+------+------+------+------+------| + * | | Alt | WH_D |Shift | Ctrl | MS_D | PgDn | Left | Down |Right | Bksp | Menu | + * |------+------+------+------+------+------+------+------+------+------+------+------| + * | WH_L | Undo | Cut | Copy |Paste |MS_B_1|MS_B_2|MS_B_3| MS_L | MS_R | WH_R | | + * |------+------+------+------+------+------+------+------+------+------+------+------| + * | | | | | | | | | | | | | + * `-----------------------------------------------------------------------------------' + */ + [_EXTEND] = LAYOUT_planck_grid( + _______, KC_ESC, KC_WH_U, KC_WBAK, KC_WFWD, KC_MS_U, KC_PGUP, KC_HOME, KC_UP, KC_END, KC_DEL, KC_ESC, + _______, KC_LALT, KC_WH_D, KC_LSFT, KC_LCTL, KC_MS_D, KC_PGDN, KC_LEFT, KC_DOWN, KC_RGHT, KC_BSPC, KC_MENU, *NOTE*: If you're wanting the Context Menu key, its keycode is actually KC_APP. ⬇️ Suggested change - _______, KC_LALT, KC_WH_D, KC_LSFT, KC_LCTL, KC_MS_D, KC_PGDN, KC_LEFT, KC_DOWN, KC_RGHT, KC_BSPC, KC_MENU, + _______, KC_LALT, KC_WH_D, KC_LSFT, KC_LCTL, KC_MS_D, KC_PGDN, KC_LEFT, KC_DOWN, KC_RGHT, KC_BSPC, KC_APP, — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8324?email_source=notifications&email_token=AFLVMSJFFYHJ5CHATTB7DDDRGFIBXA5CNFSM4LDALHTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYLKWBA#pullrequestreview-370584324>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFLVMSJEKPQT4TZYBMYU46TRGFIBXANCNFSM4LDALHTA> .