buildfix for Travis failing on mxss:default because of custom rgblight #8382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis fails on mxss:default because it uses a custom rgblight implementation instead of the qmk/quantum one, which was refactored in qmk#7773
JohSchneider
changed the title
13 tasks
|
Fixed with #8388, at that maintains existing animation logic. |
|
even better - thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis fails on mxss:default because it uses a custom rgblight implementation instead of the qmk/quantum one, which was refactored in #7773
Description
Types of Changes
Issues Fixed or Closed by This PR
[ERRORS]
In file included from keyboards/mxss/rgblight.c:30:0:
keyboards/mxss/rgblight.h:19:31: fatal error: rgblight_reconfig.h: No such file or directory
compilation terminated.
Checklist