Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP60 VIA cleanups #8697

Merged
merged 2 commits into from
Apr 13, 2020
Merged

DP60 VIA cleanups #8697

merged 2 commits into from
Apr 13, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Apr 5, 2020

Description

Cleaning up this old board to better adhere with new VIA changes.

Things changed

  • Matrix size was incorrect, how did we go so long without detecting it? lol.
  • VIA keymap only had 2 layers defined. Defined 4.
  • Added LTO_ENABLE in the VIA rules.mk file

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team April 12, 2020 17:53
@Erovia Erovia merged commit 6452973 into qmk:master Apr 13, 2020
calmh added a commit to calmh/qmk_firmware that referenced this pull request Apr 13, 2020
* master: (973 commits)
  Fix AVR SPI parameter configuration, remove timeouts due to sync protocol. (qmk#8775)
  VIA Support: Jane V2 (qmk#8735)
  Add a simple custom keymap for Gergo. (qmk#8662)
  Add via support to keebio/bdn9 (qmk#8620)
  DP60 VIA cleanups (qmk#8697)
  Adding Niu Mini to VIA (qmk#8702)
  Allow trailing whitespace in markdown docs, for formatting purposes. (qmk#8774)
  Add support for hardware and board initialisation overrides. (qmk#8330)
  [Keyboard] Add IDOBAO ID80 (qmk#8728)
  [Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729)
  [Keyboard] Add handwired Fc200rt qmk board (qmk#8726)
  Bugfix for quantum/dip_switch.c (qmk#8731)
  Add *OPT aliases for *ALT keycodes and macros (qmk#8714)
  [Keymap] Add keymap for Nyquist rev3 (qmk#8706)
  format code according to conventions [skip ci]
  Added Workman ZXCVM variation (qmk#8686)
  [Keyboard] jotpad16 status leds (qmk#8643)
  [Keyboard] Add handwired BDN9-BLE (qmk#8192)
  Fix bug with layer caching in get_event_keycode (qmk#8693)
  [Keyboard] Add CannonKeys Atlas keyboard (qmk#8207)
  ...
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
* some via cleanups for the dp60 firmware

* update matrix size
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* some via cleanups for the dp60 firmware

* update matrix size
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
* some via cleanups for the dp60 firmware

* update matrix size
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* some via cleanups for the dp60 firmware

* update matrix size
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* some via cleanups for the dp60 firmware

* update matrix size
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* some via cleanups for the dp60 firmware

* update matrix size
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* some via cleanups for the dp60 firmware

* update matrix size
@mechmerlin mechmerlin deleted the feature/dp60_via branch January 26, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants