Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keymap] fix OLED display on Helix keyboard keymaps default and five_rows #8737

Merged
merged 1 commit into from
Apr 11, 2020
Merged

[Keymap] fix OLED display on Helix keyboard keymaps default and five_rows #8737

merged 1 commit into from
Apr 11, 2020

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Apr 8, 2020

Description

Since #7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
fix OLED display on helix default and five_rows
93d1349 
Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
@zvecr zvecr requested a review from a team April 8, 2020 22:11
@zvecr zvecr added the keymap label Apr 8, 2020
Erovia
Erovia approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Erovia Erovia merged commit 511fe64 into qmk:master Apr 11, 2020
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request Apr 12, 2020
@mtei @violet-fish
[Keymap] fix OLED display on Helix keyboard keymaps default and… (qmk…
1c03a70 
…#8737)

Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@mtei @Quarren42
[Keymap] fix OLED display on Helix keyboard keymaps default and… (qmk…
2d3715a 
…#8737)

Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
@mtei mtei deleted the fix_helix_2keymaps_oled_display branch April 21, 2020 12:56
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@mtei @kujawakk
[Keymap] fix OLED display on Helix keyboard keymaps default and… (qmk…
45a1d3b 
…#8737)

Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@mtei @lorenzoernesto
[Keymap] fix OLED display on Helix keyboard keymaps default and… (qmk…
da3a8f7 
…#8737)

Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@mtei @sowbug
[Keymap] fix OLED display on Helix keyboard keymaps default and… (qmk…
2c7fd52 
…#8737)

Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@mtei @turky
[Keymap] fix OLED display on Helix keyboard keymaps default and… (qmk…
5c83926 
…#8737)

Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@mtei @jakobaa
[Keymap] fix OLED display on Helix keyboard keymaps default and… (qmk…
0316437 
…#8737)

Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
thorstenweber83 pushed a commit to thorstenweber83/qmk_firmware that referenced this pull request Sep 2, 2020
@mtei @thorstenweber83
[Keymap] fix OLED display on Helix keyboard keymaps default and… (qmk…
eaca22c 
…#8737)

Since qmk#7773, the mode number of RGBlight is no longer displayed on the Helix OLEDs. I fixed this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtei @Erovia @zvecr