[Keyboard] Add splitish #8751
Merged
[Keyboard] Add splitish #8751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap
ridingqwerty
requested changes
Apr 10, 2020
ridingqwerty
approved these changes
Apr 10, 2020
tzarc
approved these changes
Apr 11, 2020
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
Apr 12, 2020
* Added personal minivan keymap, and started work on splitish directory * Merge branch 'splitish' of github.com:RSchneyer/qmk_firmware into splitish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap * Removed personal Minivan keymaps * Fixed small issue in readme * Added changes based on inital PR feedback * forgot a semicolon * Quick config.h file and default keymap update
Quarren42
pushed a commit
to Quarren42/qmk_firmware
that referenced
this pull request
Apr 15, 2020
* Added personal minivan keymap, and started work on splitish directory * Merge branch 'splitish' of github.com:RSchneyer/qmk_firmware into splitish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap * Removed personal Minivan keymaps * Fixed small issue in readme * Added changes based on inital PR feedback * forgot a semicolon * Quick config.h file and default keymap update
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Added personal minivan keymap, and started work on splitish directory * Merge branch 'splitish' of github.com:RSchneyer/qmk_firmware into splitish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap * Removed personal Minivan keymaps * Fixed small issue in readme * Added changes based on inital PR feedback * forgot a semicolon * Quick config.h file and default keymap update
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
* Added personal minivan keymap, and started work on splitish directory * Merge branch 'splitish' of github.com:RSchneyer/qmk_firmware into splitish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap * Removed personal Minivan keymaps * Fixed small issue in readme * Added changes based on inital PR feedback * forgot a semicolon * Quick config.h file and default keymap update
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
* Added personal minivan keymap, and started work on splitish directory * Merge branch 'splitish' of github.com:RSchneyer/qmk_firmware into splitish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap * Removed personal Minivan keymaps * Fixed small issue in readme * Added changes based on inital PR feedback * forgot a semicolon * Quick config.h file and default keymap update
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
* Added personal minivan keymap, and started work on splitish directory * Merge branch 'splitish' of github.com:RSchneyer/qmk_firmware into splitish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap * Removed personal Minivan keymaps * Fixed small issue in readme * Added changes based on inital PR feedback * forgot a semicolon * Quick config.h file and default keymap update
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* Added personal minivan keymap, and started work on splitish directory * Merge branch 'splitish' of github.com:RSchneyer/qmk_firmware into splitish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap * Removed personal Minivan keymaps * Fixed small issue in readme * Added changes based on inital PR feedback * forgot a semicolon * Quick config.h file and default keymap update
thorstenweber83
pushed a commit
to thorstenweber83/qmk_firmware
that referenced
this pull request
Sep 2, 2020
* Added personal minivan keymap, and started work on splitish directory * Merge branch 'splitish' of github.com:RSchneyer/qmk_firmware into splitish Trying to undo attempted fix Added splitish keyboard files, removed personal Minivan keymap * Removed personal Minivan keymaps * Fixed small issue in readme * Added changes based on inital PR feedback * forgot a semicolon * Quick config.h file and default keymap update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the splitish keyboard (repo here). I accidentally squashed all my separate commits into a mega-commit when I was trying to remove some unrelated keymaps, will that be an issue?
I'm using the board to write this PR, so the keymap compiles, but I'm not entirely sure if the code meets QMK's standards, or if I need to write any tests.
Types of Changes
Checklist