Miscellaneous stuff: remove clang-complete and autocomplete.sh, fix some rules.mk comments #8784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome rules.mk comments
zvecr
approved these changes
Apr 13, 2020
noroadsleft
approved these changes
Apr 15, 2020
|
Thanks! |
galactic1969
added a commit
to galactic1969/qmk_firmware
that referenced
this pull request
Apr 16, 2020
* upstream/master: (1967 commits) [Docs] Japanese translation of docs/feature_combo.md (qmk#8671) Remove old setup scripts (qmk#8811) [Keyboard] ProjectKB Alice rev2 (qmk#8718) MILC: Fix setting config values for store_true and store_false (qmk#8813) KC60 Refactor (qmk#8782) Fix quick7 build command (qmk#8812) Miscellaneous stuff: remove clang-complete and autocomplete.sh, fix some rules.mk comments (qmk#8784) [Keyboard] add new keyboard quick7 (qmk#8670) [Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752) [keyboard] Add kudox rev3 (qmk#8704) CLI: Fix doctor error when can't run `bin/qmk --version`. (qmk#8796) deleted unused keymap (qmk#8797) Add missing repository name to qmk setup w/ github (qmk#8792) Configure RGBLIGHT_SPLIT for Mint60 (qmk#8788) [Keyboard] Aplx6 (qmk#8727) update pvinis keymap (qmk#8746) CLI: Use `shutil.which` to detect gmake, instead of OS check. CLI: Invoke gmake on FreeBSD when using `qmk compile`. [Docs] Japanese translation of docs/feature_dip_switch.md (qmk#8673) Fix broken KBD8X MKII Hardware link (qmk#8787) ...
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…ome rules.mk comments (qmk#8784)
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
May 3, 2020
…ome rules.mk comments (qmk#8784)
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
…ome rules.mk comments (qmk#8784)
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
…ome rules.mk comments (qmk#8784)
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
…ome rules.mk comments (qmk#8784)
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 12, 2020
…ome rules.mk comments (qmk#8784)
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
…ome rules.mk comments (qmk#8784)
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
…ome rules.mk comments (qmk#8784)
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
…ome rules.mk comments (qmk#8784)
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…ome rules.mk comments (qmk#8784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.clang_complete is a generated file; it should not be tracked. @bennypowers just a heads up here :)
autocomplete.sh has also been deleted. It uses the old makefile syntax and hardcodes the list of keyboards and keymaps. The CLI is probably the way forward for any autocompletion stuff to work with.
Lastly, just nitpicking some
MCU/BOOTLOADERcomments that weren't per the template. I'm thinking, though, that perhaps we should just let the docs list the valid values ofBOOTLOADER. Something for the next breaking cycle, maybe.Types of Changes
Issues Fixed or Closed by This PR
Checklist