[Keyboard] add dual-direction diode capability for hbcp #8795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
reviewed
Apr 14, 2020
drashna
approved these changes
Apr 14, 2020
zvecr
requested changes
Apr 14, 2020
As a passing comment, technically it will change scan speed which for some users might be less than ideal. |
zvecr
approved these changes
Apr 14, 2020
nooges
approved these changes
Apr 15, 2020
|
Ah, I see that @zvecr helped you get the lite custom matrix stuff implemented here. Good! :) |
drashna
changed the title
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* add dual-direction diode capability * update per PR requests Co-authored-by: hineybush <hineybushkeyboards@gmail.com>
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
May 3, 2020
* add dual-direction diode capability * update per PR requests Co-authored-by: hineybush <hineybushkeyboards@gmail.com>
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
* add dual-direction diode capability * update per PR requests Co-authored-by: hineybush <hineybushkeyboards@gmail.com>
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
* add dual-direction diode capability * update per PR requests Co-authored-by: hineybush <hineybushkeyboards@gmail.com>
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
* add dual-direction diode capability * update per PR requests Co-authored-by: hineybush <hineybushkeyboards@gmail.com>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* add dual-direction diode capability * update per PR requests Co-authored-by: hineybush <hineybushkeyboards@gmail.com>
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
* add dual-direction diode capability * update per PR requests Co-authored-by: hineybush <hineybushkeyboards@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So my PCB manufacturer messed up. Instead of common cathode diodes like I specced (MMBD4148CC) they used dual-direction (MMBD4148SE). This posed an issue as my original COL2ROW-only firmware would not work, understandably. @nooges from Keeb.io suggested that I look at PR #8160 and try these adjustments out. I built based on that PR and the PCB with the wrong diodes worked perfectly. I added the changes to an hbcp-specific matrix.c and adjusted the configs with @drashna's help.
I'm adding the changes here because 1. it won't affect the "correct" HBCP PCBs with common cathode diode packages and 2. anyone building their own firmware from here, or updated VIA builds, won't be done by me - so the changes should be here for anyone to access. Once #8160 is merged, I will adjust the code within hbcp accordingly.
MMBD4148CC/SE datasheet here: https://www.onsemi.com/pub/Collateral/MMBD4148SE-D.pdf
Types of Changes
Issues Fixed or Closed by This PR
Checklist