Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all KPRepublic keyboards in the same directory #9514

Closed
wants to merge 1 commit into from

Conversation

GreatWizard
Copy link
Contributor

@GreatWizard GreatWizard commented Jun 23, 2020

This PR is similar to #5206 but we don't have to have fun with conflicts and it only moves boards into a subdirectory.

We should open smaller PR, extract from #5206, about the other changes (if they are still relevant) that are not related to the move of boards.

Description

To reduce clutter in the keyboards/ directory, this PR adds a kprepublic folder to collate all boards under one parent:

  • bm16a
  • bm16s
  • bm43a
  • bm60rgb
  • cospad
  • daisy
  • jj4x4
  • jj40
  • jj50
  • staryu
  • xd0002
  • xd0004
  • xd60
  • xd68
  • xd75
  • xd84
  • xd87
  • xd96

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

close #5206

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@GreatWizard GreatWizard force-pushed the refactor/kprepublic branch from 13f8b25 to 8ab7742 Compare June 23, 2020 15:02
@zvecr zvecr added breaking_change Changes that need to wait for a version increment duplicate keyboard labels Jun 23, 2020
@GreatWizard GreatWizard mentioned this pull request Jun 23, 2020
13 tasks
@yanfali
Copy link
Contributor

yanfali commented Jun 23, 2020

This one is further along #5206

@yanfali
Copy link
Contributor

yanfali commented Jun 23, 2020

looks like a dupe.

@GreatWizard
Copy link
Contributor Author

GreatWizard commented Jun 23, 2020

Yes it's the idea of #5206: only move directories and fix make commands
I think #5206 is too hard to rebase without headache and it's more than 1 year old: there are a lot of new kprepublic boards in qmk and changes that conflict.

@GreatWizard GreatWizard force-pushed the refactor/kprepublic branch 2 times, most recently from 656b9cc to b091f4f Compare June 28, 2020 17:35
@GreatWizard GreatWizard force-pushed the refactor/kprepublic branch from b091f4f to 9c3c5d6 Compare June 28, 2020 17:56
@zvecr
Copy link
Member

zvecr commented Jun 28, 2020

#5206 isnt too bad to rebase, has additional review context, plus i am still active on the project. The missing context is that the PR has dropped out of the last 2 merge windows due to internal discussions.

For now im going to close this one as a duplicate.

@zvecr zvecr closed this Jun 28, 2020
@GreatWizard GreatWizard deleted the refactor/kprepublic branch June 29, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment duplicate keyboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants