Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ergodox Infinity: Add EE_HANDS support. #9527

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

firetech
Copy link
Contributor

Add EE_HANDS support to Ergodox Infinity.

Description

Ergodox Infinity doesn't use the split_common framework, but either half (or both) can be connected to the computer (with the second half optionally connected to that half, to make them behave as a single keyboard). Currently, the two halves must be flashed with separate firmwares to be able to work "in both directions", which requires QMK to be rebuilt with MASTER=right.

This PR adds the ability to use the EE_HANDS feature on Ergodox Infinity, making it possible to flash both halves with the same firmware and still have them behave properly, regardless of how the two halves are connected to the computer. I also added a guide to set the required EEPROM values (in ergodox_infinity/readme.md), as it's currently a bit awkward on devices using dfu-util.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Including a guide to set these EEPROM values (in the readme).
@firetech
Copy link
Contributor Author

Quite sure the Travis errors are unrelated...

@drashna
Copy link
Member

drashna commented Jul 5, 2020

Travis CI errors are community layouts not designed for the ergodox infinity. So should be fine.

@drashna drashna requested a review from a team July 5, 2020 02:27
@stale
Copy link

stale bot commented Aug 19, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

@stale stale bot removed the awaiting changes label Aug 19, 2020
@noroadsleft noroadsleft requested a review from a team August 19, 2020 05:57
@drashna drashna requested review from fauxpark, tzarc and zvecr August 22, 2020 20:45
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#pragma weak

@stale
Copy link

stale bot commented Oct 7, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@zvecr zvecr merged commit cacf495 into qmk:master Oct 11, 2020
@zvecr
Copy link
Member

zvecr commented Oct 11, 2020

Thanks!

@firetech firetech deleted the ergodox_infinity_eehands branch October 12, 2020 08:29
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
Including a guide to set these EEPROM values (in the readme).
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
Including a guide to set these EEPROM values (in the readme).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants