-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ergodox Infinity: Add EE_HANDS support. #9527
Conversation
Including a guide to set these EEPROM values (in the readme).
Quite sure the Travis errors are unrelated... |
Travis CI errors are community layouts not designed for the ergodox infinity. So should be fine. |
Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__attribute__ ((weak))
✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#pragma weak
Thank you for your contribution! |
Thanks! |
Including a guide to set these EEPROM values (in the readme).
Including a guide to set these EEPROM values (in the readme).
Add EE_HANDS support to Ergodox Infinity.
Description
Ergodox Infinity doesn't use the split_common framework, but either half (or both) can be connected to the computer (with the second half optionally connected to that half, to make them behave as a single keyboard). Currently, the two halves must be flashed with separate firmwares to be able to work "in both directions", which requires QMK to be rebuilt with MASTER=right.
This PR adds the ability to use the EE_HANDS feature on Ergodox Infinity, making it possible to flash both halves with the same firmware and still have them behave properly, regardless of how the two halves are connected to the computer. I also added a guide to set the required EEPROM values (in ergodox_infinity/readme.md), as it's currently a bit awkward on devices using dfu-util.
Types of Changes
Checklist