Move Wete to ramonimbao folder #9569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erovia
changed the title
Erovia
requested changes
Jun 28, 2020
There was a problem hiding this comment.
Removed "breaking" from the title,cause it's not a breaking one.
This PR only seem to copy the wete files instead of moving them.
I'd recommend moving them with git, so it know that the files were only moved:
mkdir keyboards/ramonibao # this directory need to exist
git mv keyboards/wete keyboards/ramonibao/ # move the files over
|
Sorry about that. I just moved the files with VS Code. |
Erovia
approved these changes
Jun 28, 2020
|
Np, it's just way cleaner this way and waaay easier to review. |
zvecr
added
the
breaking_change
|
I should really read better... |
zvecr
removed
the
breaking_change
zvecr
approved these changes
Jun 28, 2020
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* [Breaking] Move Wete to ramonimbao folder * Delete files * Move files with git instead * Update readme with new directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the
wetefolder fromkeyboards/wetetokeyboards/ramonimbao/weteas per #9495 (comment).The GB for this keyboard is not yet fulfilled and has yet to be shipped to customers.
Types of Changes
Issues Fixed or Closed by This PR
Checklist