Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Fix inconsistent MATRIX_COLS: 4pplet/steezy60 #9678

Merged
merged 1 commit into from
Jul 10, 2020
Merged

[Keyboard] Fix inconsistent MATRIX_COLS: 4pplet/steezy60 #9678

merged 1 commit into from
Jul 10, 2020

Conversation

elfmimi
Copy link
Contributor

@elfmimi elfmimi commented Jul 8, 2020

Description

Similar to #8115 #8150 #9022

MATRIX_COLS is wrongly defined larger than it should be.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@elfmimi elfmimi mentioned this pull request Jul 9, 2020
Merged
13 tasks
@zvecr zvecr added the keyboard label Jul 9, 2020
@zvecr zvecr requested a review from a team July 9, 2020 22:14
@fauxpark fauxpark merged commit c272b24 into qmk:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@4pplet 4pplet 4pplet approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elfmimi @4pplet @fauxpark @zvecr