Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PCB Hannah910 rev3 #9710

Merged
merged 8 commits into from
Aug 4, 2020
Merged

add PCB Hannah910 rev3 #9710

merged 8 commits into from
Aug 4, 2020

Conversation

mechlovin
Copy link
Contributor

Description

Add Hannah910-rev3

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Jul 17, 2020
@zvecr zvecr requested a review from a team July 17, 2020 14:09
fauxpark
fauxpark requested changes Jul 17, 2020
View reviewed changes
keyboards/mechlovin/hannah910/rev3/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/rules.mk Outdated Show resolved Hide resolved
@mechlovin
Copy link
Contributor Author

all updated.
Thanks!

@mechlovin mechlovin mentioned this pull request Jul 29, 2020
Merged
6 tasks
fauxpark
fauxpark requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR lint is throwing these:

☒ mechlovin/hannah910/rev3: LAYOUT_all: Number of elements in info.json does not match! info.json:73 != LAYOUT_all:71
☒ mechlovin/hannah910/rev3: LAYOUT_ansi: Number of elements in info.json does not match! info.json:68 != LAYOUT_ansi:66

noroadsleft
noroadsleft requested changes Jul 31, 2020
View reviewed changes
keyboards/mechlovin/hannah910/rev3/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/keymaps/ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/keymaps/ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/keymaps/ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/keymaps/ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/rev3.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev3/rules.mk Outdated Show resolved Hide resolved
noroadsleft
noroadsleft approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@drashna drashna merged commit 2c9e210 into qmk:master Aug 4, 2020
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@mechlovin @nicocesar
[Keyboard] add Hannah910 rev3 (qmk#9710)
90cf8f0
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@mechlovin @fcoury
[Keyboard] add Hannah910 rev3 (qmk#9710)
f2d60cb
@mechlovin mechlovin mentioned this pull request Sep 3, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mechlovin @drashna @fauxpark @noroadsleft @zvecr