-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterf-docker: Set weight=0 for stopping containers #5
Comments
Implemented in the new
With etcd getting updated appropriately:
|
SpComb
pushed a commit
that referenced
this issue
May 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Containers that are in the process of being stopped, but not yet down, should still be present as backends with their weight set to zero. Once the container is torn down (the IP address no longer exists), it is safe to remove the backend.
Ideally this would allow clean shutdown of service backends, with the
docker stop ...
command triggering a a weight=0 update and SIGKILL to the service to allow existing connections to finish processing, and then once the service exits, the backend is removed.Needs some more awareness of docker container events/lifecycles in
github.com/qmsk/clusterf/docker
to provide bothRunning
andStopping
flags inContainerEvent
.The text was updated successfully, but these errors were encountered: