[ML] Add job timing stats to anomaly jobs (elastic#65696)

* [ML] Add anomaly job timing stats to Counts & JSON * [ML] Remove roundTo3DecimalPlace and clean up * [ML] Fix format_values to round decimals for time values * [ML] Remove timing_stats and forecast_stats from cloneJob * [ML] Remove timing_stats & forecasts in job_service instead of utils
qn895 · May 8, 2020 · 9a53c32 · 9a53c32
1 parent e7bbb7d
commit 9a53c32
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 5 deletions.
diff --git a/...lugins/ml/public/application/jobs/jobs_list/components/job_details/extract_job_details.js b/...lugins/ml/public/application/jobs/jobs_list/components/job_details/extract_job_details.js
@@ -165,6 +165,15 @@ export function extractJobDetails(job) {
     items: filterObjects(job.model_size_stats).map(formatValues),
   };
 
+  const jobTimingStats = {
+    id: 'jobTimingStats',
+    title: i18n.translate('xpack.ml.jobsList.jobDetails.jobTimingStatsTitle', {
+      defaultMessage: 'Job timing stats',
+    }),
+    position: 'left',
+    items: filterObjects(job.timing_stats).map(formatValues),
+  };
+
   const datafeedTimingStats = {
     id: 'datafeedTimingStats',
     title: i18n.translate('xpack.ml.jobsList.jobDetails.datafeedTimingStatsTitle', {
@@ -192,6 +201,7 @@ export function extractJobDetails(job) {
     datafeed,
     counts,
     modelSizeStats,
+    jobTimingStats,
     datafeedTimingStats,
   };
 }
diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/format_values.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/format_values.js
@@ -63,6 +63,12 @@ export function formatValues([key, value]) {
     // numbers rounded to 3 decimal places
     case 'average_search_time_per_bucket_ms':
     case 'exponential_average_search_time_per_hour_ms':
+    case 'total_bucket_processing_time_ms':
+    case 'minimum_bucket_processing_time_ms':
+    case 'maximum_bucket_processing_time_ms':
+    case 'average_bucket_processing_time_ms':
+    case 'exponential_average_bucket_processing_time_ms':
+    case 'exponential_average_bucket_processing_time_per_hour_ms':
       value = typeof value === 'number' ? roundToDecimalPlace(value, 3).toLocaleString() : value;
       break;
 

diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_details.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_details.js
@@ -60,6 +60,7 @@ export class JobDetails extends Component {
         datafeed,
         counts,
         modelSizeStats,
+        jobTimingStats,
         datafeedTimingStats,
       } = extractJobDetails(job);
 
@@ -102,7 +103,7 @@ export class JobDetails extends Component {
           content: (
             <JobDetailsPane
               data-test-subj="mlJobDetails-counts"
-              sections={[counts, modelSizeStats]}
+              sections={[counts, modelSizeStats, jobTimingStats]}
             />
           ),
         },

diff --git a/x-pack/plugins/ml/public/application/services/job_service.js b/x-pack/plugins/ml/public/application/services/job_service.js
@@ -369,6 +369,8 @@ class JobService {
     delete tempJob.open_time;
     delete tempJob.established_model_memory;
     delete tempJob.calendars;
+    delete tempJob.timing_stats;
+    delete tempJob.forecasts_stats;
 
     delete tempJob.analysis_config.use_per_partition_normalization;
 

diff --git a/x-pack/plugins/ml/server/models/job_service/jobs.ts b/x-pack/plugins/ml/server/models/job_service/jobs.ts
@@ -328,7 +328,7 @@ export function jobsProvider(callAsCurrentUser: APICaller) {
     // create jobs objects containing job stats, datafeeds, datafeed stats and calendars
     if (jobResults && jobResults.jobs) {
       jobResults.jobs.forEach(job => {
-        const tempJob = job as CombinedJobWithStats;
+        let tempJob = job as CombinedJobWithStats;
 
         const calendars: string[] = [
           ...(calendarsByJobId[tempJob.job_id] || []),
@@ -341,9 +341,7 @@ export function jobsProvider(callAsCurrentUser: APICaller) {
         if (jobStatsResults && jobStatsResults.jobs) {
           const jobStats = jobStatsResults.jobs.find(js => js.job_id === tempJob.job_id);
           if (jobStats !== undefined) {
-            tempJob.state = jobStats.state;
-            tempJob.data_counts = jobStats.data_counts;
-            tempJob.model_size_stats = jobStats.model_size_stats;
+            tempJob = { ...tempJob, ...jobStats };
             if (jobStats.node) {
               tempJob.node = jobStats.node;
             }