feat: use KeyboardEvent.key instead of KeyboardEvent.keyCode #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legallai
pushed a commit
to legallai/ember-amount-input
that referenced
this pull request
Jul 2, 2024
feat: use KeyboardEvent.key instead of KeyboardEvent.keyCode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR goal is to get rid of the usage of
KeyboardEvent.keyCodewhich is a deprecated standard as you can see on MDN documentation. As of today, this is still supported by all browsers but might no be the case in the future.Two API have the potential to replace
keyCodeand they'reKeyboardEvent.codeandKeyboardEvent.key.KeyboardEvent.codereturns a representation of the key pressed whileKeyboardEvent.keyreturns the value as it will be printed. In our case, we want to exclude specific printed values sokeyusage makes more sense.Also,
KeyboardEvent.keyis more supported by browsers (partial support up to IE 8 for instance).This PR closes #612 issue.
Reproduction instructions
Tests should pass.