Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant catch block #29

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Remove redundant catch block #29

merged 1 commit into from
Jan 26, 2023

Conversation

herzzanu
Copy link
Contributor

We don't want to catch the error in case there's a network error, just to throw a custom error. Let's have the consuming apps handle this.

@herzzanu herzzanu self-assigned this Jan 26, 2023
@herzzanu herzzanu merged commit 565f24e into main Jan 26, 2023
@herzzanu herzzanu deleted the remove-lottie-catch branch January 26, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickschot nickschot nickschot approved these changes

Assignees

@herzzanu herzzanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herzzanu @nickschot