Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to github ci and drop support for Ember 3.4 and 3.8 #348

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Jul 30, 2021

Description

Since Travis has gone bye bye 😢 it's about time to move to github actions for CI 🎉 Hopefully this PR will achieve this.

Note: this isn't considered a breaking change even though I'm removing tests for 3.4 and 3.8 becuase they were already failing before this PR. There is a chance that we've broken semver at some point in the past but we don't know because Travis has stopped working and it's hard to figure it out 😞

Also we expect the floating dependencies test to fail, along with ember canary 👍 so we can merge even if they fail

@dcyriller
Copy link
Contributor

Thanks a lot @mansona!

I'm looking at the commits on the main branch. It seems the CI has been failing for 3.8 for the first time when we merged this ember-cli upgrade. It was two PRs ago, no release has been done so far.

I am all 👍 with removing the test suite for 3.4 and 3.8. That said the last version we published was working well with these versions. This is why I think we should release a major to drop support for these versions. Is it okay by you?

@dcyriller dcyriller merged commit 22848be into qonto:master Jul 30, 2021
@mansona
Copy link
Contributor Author

mansona commented Aug 6, 2021

Yes I'm happy with this being a breaking version 👍 it's safer than my proposal and that's always a good thing 😂

@mansona mansona changed the title move to github ci move to github ci and drop support for Ember 3.4 and 3.8 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants