Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from yarn to pnpm #625

Merged
merged 2 commits into from
May 23, 2023
Merged

Migrate from yarn to pnpm #625

merged 2 commits into from
May 23, 2023

Conversation

vscav
Copy link
Member

@vscav vscav commented May 23, 2023

Description

pnpm is used instead of yarn to manage the project.

Changes

  • pnpm is used instead of yarn
    • "workspaces" field is removed from package.json because it is not supported by pnpm - we use a pnpm-workspace.yaml file instead
    • pnpm is removed from Volta because support is currently experimental

Checklist

  • Update package.json scripts to use pnpm
  • Run build, lint and test scripts locally
  • Update CI jobs to use pnpm

@vscav vscav self-assigned this May 23, 2023
@vscav vscav changed the title Migrate from Yarn to pnpm Migrate from yarn to pnpm May 23, 2023
@vscav vscav force-pushed the migrate-to-pnpm branch 2 times, most recently from 0443663 to 4bebab2 Compare May 23, 2023 13:22
@vscav vscav marked this pull request as ready for review May 23, 2023 13:29
@vscav vscav requested a review from anas7asia May 23, 2023 13:29
@anas7asia

This comment was marked as resolved.

@vscav
Copy link
Member Author

vscav commented May 23, 2023

Should yarn.lock be added to gitignore?

@anas7asia It's done, thanks for spotting! I also took the opportunity to ignore the package-lock.json as well

@vscav vscav merged commit 9f54f48 into master May 23, 2023
@vscav vscav deleted the migrate-to-pnpm branch May 23, 2023 14:45
@vscav vscav added the internal label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants