Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ember to v4.12 #18

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Upgrade Ember to v4.12 #18

merged 3 commits into from
Apr 12, 2023

Conversation

anas7asia
Copy link
Contributor

@anas7asia anas7asia commented Apr 11, 2023

Description

Ember is upgraded to latest 4.12 version with the help of ember-cli-update codemod.

Changes

  • Ember dependencies are upgraded to latest versions
  • Support is dropped for ember-3.16, ember-3.20, ember-default-with-jquery and ember-classic ⚠️

@anas7asia anas7asia self-assigned this Apr 11, 2023
@anas7asia anas7asia changed the title Upgrade ember to v4.12 Upgrade Ember to v4.12 Apr 11, 2023
@anas7asia anas7asia force-pushed the upgrade-ember branch 2 times, most recently from d91c838 to 9a4acaa Compare April 11, 2023 15:02
.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@dbendaou dbendaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments otherwise lgtm

.eslintrc.js Outdated Show resolved Hide resolved
@anas7asia anas7asia force-pushed the upgrade-ember branch 2 times, most recently from 53f3e01 to e9e9c0f Compare April 11, 2023 16:18
Copy link
Contributor

@crushjz crushjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@anas7asia anas7asia merged commit 3d08ff1 into main Apr 12, 2023
@michelegera michelegera deleted the upgrade-ember branch October 2, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants