Null input fix

[jmorganmartin]

First commit prevents errors / false-positives on length and RegExp checks if input value is null or false.

2nd commit updates package.json to prevent build error/conflict with gulp-rollup@2.15.0

[tonivj5]

Thanks @jmorganmartin for your fantastic work! I will review soon 👍

[tonivj5]

Thanks 👍

[tonivj5]

It should be value != null && value !== false because undefined is convert to string too (value != null check null and and `undefinedp ). And I think it would be clearest without brkackets 👍

[jmorganmartin]

Since it's Typescript, can we just do .test(value ? value : '') ?

[jmorganmartin]

I guess, not because it could be 0.

[jmorganmartin]

@xxxTonixxx Updated with your suggestion. Let me know if I can help get this released. It's causing a lot of errors in one of my projects.

[tonivj5]

😄

[tonivj5]

Thanks @jmorganmartin for your work! I just have uploaded a new version 0.2.0-alpha.12 ! I hope it helps in your projects 👍

[360disrupt]

Version 0.2.0-alpha.12
I have

    const expertiseForm = this.formBuilder.group({
      language: [ '' ],
      description: [ null ],
      since: [ undefined ],
    });

<form [formGroupName]="index" [id]="'expertise'+index">
            {{returnType(expertise.get('language').value)}}
            <div class="row">
              <div class="form-group required col-xs-12 col-md-12">
                <label class="inline-control-label">Language</label>
                <inline-editor type="text" class="inline-form-control" empty="type in your language e.g. JS" (onSave)="checkMe($event)" formControlName="language" placeholder="E.g. javascript" required></inline-editor>
              </div>
            </div>

None of the three options shows the empty value instead nothing is shown => thus nothing is editable.

If I enter string values it works:

Problem only appears if the initial value is null|undefined|'' this works:
setTimeout( () => expertiseForm.patchValue({ language: null, description: null, since: null }), 1000)