Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#60 Add image viewer. #61

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

#60 Add image viewer. #61

wants to merge 5 commits into from

Conversation

Illia-M
Copy link

@Illia-M Illia-M commented Aug 8, 2024

Add fancybox for image preview - very nice library.
When download folder - try use name of folder as archive name.

@qoomon
Copy link
Owner

qoomon commented Aug 8, 2024

N1. Could you merge master branch, because I already implemented the download archive naming.

@qoomon
Copy link
Owner

qoomon commented Aug 8, 2024

Would be nice to display markdown preview alike to images. maybe load markdown in an iframe could be a simple solution

@Illia-M
Copy link
Author

Illia-M commented Aug 8, 2024

  1. in my case folder name contains Ukrainian chars and was url encoded so I need decodeURIComponent for name before use it in file name. I try catch errors if some how name extraction failed.
  2. I think a lot about markdown files, separate tab it's useful for some cases but in my it will be nice display in same table view if only one md file inside folder, maybe only for some name.

But for this PR I want only merge image preview)
Thank you for refactoring, I'm not familiar with JS stack. Editorsconfig would be great help to met rules.

Can we merge it? Folder naming can be here, separate PR or I can leave it for my fork

@Illia-M Illia-M changed the title #60 Add image viewer. Update archive name on download WIP: #60 Add image viewer. Update archive name on download Aug 8, 2024
@Illia-M
Copy link
Author

Illia-M commented Aug 8, 2024

I want update and fine-tune this lib

@Illia-M Illia-M changed the title WIP: #60 Add image viewer. Update archive name on download #60 Add image viewer. Update archive name on download Aug 8, 2024
@qoomon
Copy link
Owner

qoomon commented Aug 9, 2024

maybe I'll go fore https://github.com/VueFilesPreview/vue-files-preview in a future release. WDYT

@qoomon
Copy link
Owner

qoomon commented Aug 15, 2024

Let's wait for VueFilesPreview/vue-files-preview#16

@qoomon qoomon changed the title #60 Add image viewer. Update archive name on download #60 Add image viewer. Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants