-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Null Version with Non-Greedy Matcher #96
Conversation
- Increasing minor version since the matcher has been updated which could cause some differnt versions to be detected which previously were not.
- Currently the matcher is non-greedy and will match 0 or 1 to handle cases when the version is not specified. This can create a null match on the first match when the entire string is not valid. The fix is to locate the first non-null match.
Split changes from #94 |
This should partially, maybe fully, address the issues in #89 |
src/main/java/me/qoomon/gradle/gitversioning/GitVersioningPluginExtension.java
Show resolved
Hide resolved
Any additional thoughts on this PR and the other open? |
Hi @ericmaino, sorry I didn't find the time to work on this project last week. LGTM sofar I'll probably merge it within the upcoming week. |
src/main/java/me/qoomon/gradle/gitversioning/GitVersioningPluginExtension.java
Outdated
Show resolved
Hide resolved
Thanks for taking a look. I have some projects updates I'm looking to move to use this plugin, however this PR and #97 currently prevent our team's ability to adopt |
No description provided.