Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Null Version with Non-Greedy Matcher #96

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

ericmaino
Copy link

No description provided.

- Increasing minor version since the matcher has been updated which could
cause some differnt versions to be detected which previously were not.
- Currently the matcher is non-greedy and will match 0 or 1 to handle cases when the version is not specified. This can create a null match on the first match when the entire string is not valid. The fix is to locate the first non-null match.
@ericmaino
Copy link
Author

Split changes from #94

@ericmaino
Copy link
Author

This should partially, maybe fully, address the issues in #89

@qoomon qoomon self-assigned this Oct 18, 2022
@qoomon qoomon added the bug Something isn't working label Oct 18, 2022
@ericmaino
Copy link
Author

Any additional thoughts on this PR and the other open?

@qoomon
Copy link
Owner

qoomon commented Oct 23, 2022

Hi @ericmaino, sorry I didn't find the time to work on this project last week. LGTM sofar I'll probably merge it within the upcoming week.

@ericmaino
Copy link
Author

Thanks for taking a look. I have some projects updates I'm looking to move to use this plugin, however this PR and #97 currently prevent our team's ability to adopt

@qoomon qoomon merged commit 9487285 into qoomon:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants