Allow reporting of logging loss in AsyncAppenderBase #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cilitate reporting loss of log events in a health check.
|
The failing travis build has no relation whatsoever with this PR. |
|
BTW, a more serious solution is to have a public counter with the number of dropped messages. |
|
I encountered the same problem today, and created https://jira.qos.ch/browse/LOGBACK-1436 to track it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made
AsyncAppenderBase.isQueueBelowDiscardingThresholdpublic to facilitate reporting loss of log events in a health check.For example, with this change one could now call
isQueueBelowDiscardingThresholdfrom a dropwizard metrics health-check.